Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: always invoke callback before emitting error #29293

Closed
wants to merge 6 commits into from
Closed

stream: always invoke callback before emitting error #29293

wants to merge 6 commits into from

Commits on Sep 20, 2019

  1. stream: always invoke callback before emitting error 

    Ensure the callback is always invoked before emitting
the error in both sync and async case.
    @ronag
    ronag committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    9f4a28f View commit details
    Browse the repository at this point in the history

  2. fixup: no finish or prefinish on errored

    @ronag
    ronag committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    1cd617b View commit details
    Browse the repository at this point in the history

  3. fixup: simplify

    @ronag
    ronag committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    5da8563 View commit details
    Browse the repository at this point in the history

  4. fixup: no finish after destroy error

    @ronag
    ronag committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    14428f3 View commit details
    Browse the repository at this point in the history

  5. fixup: remove unused errorMaybe

    @ronag
    ronag committed Sep 20, 2019
    Configuration menu
    Copy the full SHA
    eb9099b View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2019

  1. fixup: remove no longer necessary test change

    @ronag
    ronag committed Sep 28, 2019
    Configuration menu
    Copy the full SHA
    60dac52 View commit details
    Browse the repository at this point in the history