tools: make code cache and snapshot deterministic #29142
Conversation
Use a fixed random seed to ensure that the generated sources are identical across runs. The final node binary still reseeds itself on start-up so there should be no security implications caused by predictable random numbers (e.g., `Math.random()`, ASLR, the hash seed, etc.) Fixes: nodejs#29108
| @@ -26,6 +26,8 @@ int wmain(int argc, wchar_t* argv[]) { | |||
| int main(int argc, char* argv[]) { | |||
| #endif // _WIN32 | |||
|
|
|||
| v8::V8::SetFlagsFromString("--random_seed=42"); | |||
There was a problem hiding this comment.
IEEE 1149.5 specifies 4 as the random number.
|
Hrm, looks like retrieval from the cache fails unless node is also started with I can work around that by resetting |
|
also @nodejs/v8 |
|
pummel/test-hash-seed: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/8546/ |
@bnoordhuis Would I be correct to conclude from the above comments that this shouldn't land yet? |
|
@Trott I incorporated the necessary fixes. bnoordhuis/io.js@ed2c673 is the fix but the timestamp may be throwing off GH because it shows up before my comment. |
|
Landed in 5116a6a |
Use a fixed random seed to ensure that the generated sources are identical across runs. The final node binary still reseeds itself on start-up so there should be no security implications caused by predictable random numbers (e.g., `Math.random()`, ASLR, the hash seed, etc.) Fixes: #29108 PR-URL: #29142 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Use a fixed random seed to ensure that the generated sources are identical across runs. The final node binary still reseeds itself on start-up so there should be no security implications caused by predictable random numbers (e.g., `Math.random()`, ASLR, the hash seed, etc.) Fixes: #29108 PR-URL: #29142 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
|
@bnoordhuis Yes, I can confirm that this fixes the issue. Thanks! |
Use a fixed random seed to ensure that the generated sources are
identical across runs.
The final node binary still reseeds itself on start-up so there should
be no security implications caused by predictable random numbers (e.g.,
Math.random(), ASLR, the hash seed, etc.)Fixes: #29108