Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exported method can be static; will never be called directly #29102

Closed
wants to merge 1 commit into from
Closed

Exported method can be static; will never be called directly #29102

wants to merge 1 commit into from

Conversation

rpoisel
Copy link
Contributor

@rpoisel rpoisel commented Aug 13, 2019

Checklist

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Aug 13, 2019
patilharshal16
patilharshal16 reviewed Aug 13, 2019
View reviewed changes
Copy link

@patilharshal16 patilharshal16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need static method?

@rpoisel
Copy link
Contributor Author

rpoisel commented Aug 13, 2019

No, you don't need it, but you might want it (encapsulation principle). :-)

I don't see any reason for having this being a symbol with global scope (as opposed to: module scope).

@addaleax
Copy link
Member

I think this is okay, but since these are test addons, it really doesn’t make a difference in practice.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25020/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25023/

@Trott
Copy link
Member

Trott commented Aug 16, 2019

Landed in 71b5ce5

@Trott Trott closed this Aug 16, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Aug 16, 2019
@rpoisel @Trott
test: make exported method static
71b5ce5 
The exported method can be static as it will never be called directly.

PR-URL: nodejs#29102
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Aug 19, 2019
@rpoisel @targos
test: make exported method static
18b7113 
The exported method can be static as it will never be called directly.

PR-URL: #29102
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patilharshal16 patilharshal16 patilharshal16 approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rpoisel @addaleax @nodejs-github-bot @Trott @cjihrig @patilharshal16