stream: improve read() performance #28961
Conversation
mscdex
added
stream
|
@mscdex Sorry to ask here. But, how do I generate/run that benchmark? |
|
Locally: $ node benchmark/compare.js --new ./node --old ./node-master --filter readable-readall -- streams | Rscript benchmark/compare.Ror run it in benchmark CI and fill out some of the same parameters. |
ZYSzys
added
the
author ready
|
@ronag |
|
Oops, I see @mscdex included the R script at the end, so ignore that part of what I wrote. But the guide link may still come in handy. |
|
Landed in 0b5b81c |
PR-URL: nodejs#28961 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
PR-URL: #28961 Reviewed-By: Weijia Wang <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Result:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes