Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test case for checking typeof mgf1Hash #27892

Closed
wants to merge 1 commit into from
Closed

test: add test case for checking typeof mgf1Hash #27892

wants to merge 1 commit into from

Conversation

Nievl
Copy link
Contributor

@Nievl Nievl commented May 26, 2019

add test case to cover uncovered test mgf1Hash param of generateKeyPair,
check typeof

Checklist
  • [ x ] make -j4 test (UNIX), or vcbuild test (Windows) passes
  • [ x ] tests and/or benchmarks are included

@Nievl
test: add test case for checking typeof mgf1Hash
093fcec 
add test case to cover uncovered test mgf1Hash param of generateKeyPair,
check typeof
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label May 26, 2019
@BridgeAR BridgeAR added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label May 26, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23342/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2019
@ryzokuken
Copy link
Contributor

Thanks everyone! Will land this as soon as 48 hours are up.

@danbev
Copy link
Contributor

danbev commented May 29, 2019

Landed in 12f5e0f.

@danbev danbev closed this May 29, 2019
danbev pushed a commit that referenced this pull request May 29, 2019
@Nievl @danbev
test: add test case for checking typeof mgf1Hash
12f5e0f 
add test case to cover uncovered test mgf1Hash param of generateKeyPair,
check typeof

PR-URL: #27892
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
targos pushed a commit that referenced this pull request May 31, 2019
@Nievl @targos
test: add test case for checking typeof mgf1Hash
67b692b 
add test case to cover uncovered test mgf1Hash param of generateKeyPair,
check typeof

PR-URL: #27892
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@targos targos mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@Nievl @nodejs-github-bot @ryzokuken @danbev @ChALkeR @Trott @addaleax @cjihrig @gireeshpunathil @BridgeAR