Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: reword Experimental stability index #27879

Merged
merged 1 commit into from
May 28, 2019
Merged

doc: reword Experimental stability index #27879

merged 1 commit into from
May 28, 2019

Conversation

Trott
Copy link
Member

@Trott Trott commented May 26, 2019

Reword the explanation of the Experimental stability index for brevity
and clarity.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

ChALkeR
ChALkeR reviewed May 26, 2019
View reviewed changes
doc/api/documentation.md Outdated Show resolved Hide resolved
ChALkeR
ChALkeR approved these changes May 26, 2019
View reviewed changes
Copy link
Member

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM.

@ChALkeR ChALkeR added doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. labels May 26, 2019
@Trott
Copy link
Member Author

Trott commented May 26, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3627/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 26, 2019
mhdawson
mhdawson approved these changes May 27, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
doc: reword Experimental stability index
fc7c5b9 
Reword the explanation of the Experimental stability index for brevity
and clarity.

PR-URL: nodejs#27879
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@Trott
Copy link
Member Author

Trott commented May 28, 2019

Landed in fc7c5b9

@Trott Trott closed this May 28, 2019
@Trott Trott merged commit fc7c5b9 into nodejs:master May 28, 2019
targos pushed a commit that referenced this pull request May 31, 2019
@Trott @targos
doc: reword Experimental stability index
f621b8f 
Reword the explanation of the Experimental stability index for brevity
and clarity.

PR-URL: #27879
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@targos targos mentioned this pull request Jun 3, 2019
Merged
@Trott Trott deleted the experimental-rewording branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@targos targos targos approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @ChALkeR @targos @mhdawson