build: improve embedded code-cache detection #27311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
added
the
build
2 tasks
mihalskiy
approved these changes
Apr 19, 2019
joyeecheung
approved these changes
Apr 19, 2019
joyeecheung
reviewed
Apr 19, 2019
refack
force-pushed
the
fix-config-code-cache-bug
branch
from
0606363
to
98deba3
Compare
|
Added |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
joyeecheung
reviewed
Apr 20, 2019
|
Ping @nodejs/build-files @nodejs/process |
joyeecheung
approved these changes
Apr 20, 2019
richardlau
approved these changes
Apr 21, 2019
refack
force-pushed
the
fix-config-code-cache-bug
branch
from
f0b5677
to
cbf534c
Compare
This comment has been minimized.
This comment has been minimized.
BridgeAR
added
the
author ready
BridgeAR
reviewed
Apr 21, 2019
BridgeAR
removed
the
author ready
refack
force-pushed
the
fix-config-code-cache-bug
branch
from
cbf534c
to
4d81c09
Compare
PR-URL: nodejs#27311 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]>
refack
force-pushed
the
fix-config-code-cache-bug
branch
from
4d81c09
to
5aaf666
Compare
This was referenced Apr 23, 2019
This was referenced Sep 12, 2024
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 17, 2024
PR-URL: #54982 Refs: aa0308d Refs: 9010f5f Refs: 52a40e0 Refs: b3ef289 Refs: #2564 Refs: #25819 Refs: #27311 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
targos
pushed a commit
that referenced
this pull request
Oct 4, 2024
PR-URL: #54982 Refs: aa0308d Refs: 9010f5f Refs: 52a40e0 Refs: b3ef289 Refs: #2564 Refs: #25819 Refs: #27311 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
louwers
pushed a commit
to louwers/node
that referenced
this pull request
Nov 2, 2024
PR-URL: nodejs#54982 Refs: nodejs@aa0308d Refs: nodejs@9010f5f Refs: nodejs@52a40e0 Refs: nodejs@b3ef289 Refs: nodejs#2564 Refs: nodejs#25819 Refs: nodejs#27311 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#54982 Refs: nodejs@aa0308d Refs: nodejs@9010f5f Refs: nodejs@52a40e0 Refs: nodejs@b3ef289 Refs: nodejs#2564 Refs: nodejs#25819 Refs: nodejs#27311 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Moshe Atlow <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #27308
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes