Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: revise Collaborator material in GOVERNANCE.md #27103

Closed
wants to merge 1 commit into from
Closed

doc: revise Collaborator material in GOVERNANCE.md #27103

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 5, 2019

  • Reduce passive voice
  • Shorter and simpler sentences
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
doc: revise Collaborator material in GOVERNANCE.md
c7fee69 
* Reduce passive voice
* Shorter and simpler sentences
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3180

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 5, 2019
@vsemozhetbyt vsemozhetbyt added the doc Issues and PRs related to the documentations. label Apr 5, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 5, 2019
@Trott
Copy link
Member Author

Trott commented Apr 8, 2019

Landed in 557bd86

@Trott Trott closed this Apr 8, 2019
Trott added a commit to Trott/io.js that referenced this pull request Apr 8, 2019
@Trott
doc: revise Collaborator material in GOVERNANCE.md
557bd86 
* Reduce passive voice
* Shorter and simpler sentences

PR-URL: nodejs#27103
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Yuta Hiroto <[email protected]>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 12, 2022
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 13, 2022
Open
Open
Open
@Trott Trott deleted the collab-revise branch January 13, 2022 22:51
This was referenced Feb 9, 2022
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@kissofire kissofire mentioned this pull request May 22, 2024
Open
@137717unity 137717unity mentioned this pull request May 22, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request May 22, 2024
Open
@baby636 baby636 mentioned this pull request May 22, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@hiroppy hiroppy hiroppy approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @jasnell @hiroppy @BridgeAR @vsemozhetbyt @ZYSzys