timers: use const to define constants #2707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v8 will silently return an empty handle which doesn't delete our data if string length is above String::kMaxLength Fixes: #1374 PR-URL: #2402 Reviewed-By: trevnorris - Trevor Norris <[email protected]> Reviewed-By: indutny - Fedor Indutny <[email protected]> Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
Add an optional callback parameter to `ChildProcess.prototype.send()` that is invoked when the message has been sent. Juggle the control channel's reference count so that in-flight messages keep the event loop (and therefore the process) alive until they have been sent. `ChildProcess.prototype.send()` and `process.send()` used to operate synchronously but became asynchronous in commit libuv/libuv@393c1c5 ("unix: set non-block mode in uv_{pipe,tcp,udp}_open"), which landed in io.js in commit 07bd05b ("deps: update libuv to 1.2.1"). Fixes: #760 PR-URL: #2620 Reviewed-By: trevnorris - Trevor Norris <[email protected]> Reviewed-By: jasnell - James M Snell <[email protected]>
This test has failed recently during a PR test in Jenkins, for reasons seemingly not related to the change in the PR. PR-URL: #2648 Reviewed-By: evanlucas - Evan Lucas <[email protected]>
Fixes: #1972 PR-URL: #2322 Reviewed-By: orangemocha - Alexis Campailla <[email protected]> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
Fixes: #2113 Ref: 17a379e PR-URL: #2605 Reviewed-By: jasnell - James M Snell <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]> Reviewed-By: mscdex - Brian White <[email protected]>
This retains the key elements of test-child-process-fork-getconnections (forks a child process, sends a bunch of sockets, uses getConnections() to enumerate them) but contains some code to work around an apparent intermittent bug that occurs on OS X where a socket seems to close itself unexpectedly. #2610 was opened for the bug that was causing the problem in the first place. PR-URL: #2609 Fixes: #1100 Reviewed-By: jbergstroem - Johan Bergström <[email protected]> Reviewed-By: Brendan Ashworth <[email protected]>
Port of joyent/node commits: * nodejs/node-v0.x-archive@e17c5a7 * nodejs/node-v0.x-archive@70dafa7 Pull over test-child-process-spawn-typeerror.js from v0.12, replacing the existing test in master. The new test includes a broader set of tests on the various arg choices and throws. Reviewed-By: trevnorris - Trevor Norris <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]> Reviewed-By: thefourtheye - Sakthipriyan Vairamani PR-URL: #2667 Fixes: #2515
PR-URL: #2376 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Now parts of our public and public-ish APIs fall back to old-style listenerCount() if the emitter does not have a listenerCount function. Fixes: #2655 Refs: 8f58fb9 PR-URL: #2661 Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
Upgrade to the latest branch-head for V8 4.5. For the full commit log see https://github.com/v8/v8-git-mirror/commits/4.5.103.24 PR-URL: #2509 Reviewed-By: Ben Noordhuis <[email protected]>
Apply the src/node_contextify.cc and lib/module.js fixups from @bnoordhuis 41e63fb PR-URL: #2509 Reviewed-By: Ben Noordhuis <[email protected]>
The `context_` is not initialized until the `CreateV8Context` will return. Make sure that it will be empty (by moving away initialization from constructor) at start, and ignore getter callbacks until it will have some value. PR-URL: #2091 Reviewed-By: Trevor Norris <[email protected]>
The list of Array properties needed to be updated to match the new ones added in V8 4.5. PR-URL: #2509 Reviewed-By: Ben Noordhuis <[email protected]>
Turn on V8 API deprecation warnings. Fix up the no-arg Isolate::New() calls in src/node.cc and src/debug-agent.cc. PR-URL: #2091 Reviewed-By: Trevor Norris <[email protected]>
v8::Handle is deprecated: https://codereview.chromium.org/1224623004 PR-URL: #2202 Reviewed-By: Ben Noordhuis <[email protected]>
The flag is no longer supported by V8 4.5, and the original issue [1] on ARMv6 no longer manifests with (at least) 4.5.103.20. [1] See https://code.google.com/p/v8/issues/detail?id=4338 PR-URL: #2509 Reviewed-By: Ben Noordhuis <[email protected]>
Ref: #1376 Ref: #1398 Issue fixed in V8: https://chromium.googlesource.com/v8/v8/+/81703350bbb9923d211fe5b79e90bd458b0916e2 V8-Bug: https://code.google.com/p/v8/issues/detail?id=4019 PR-URL: #2592 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Pick up v8/v8@f9a0a16 Commit log at https://chromium.googlesource.com/v8/v8.git/+log/branch-heads/4.5 PR-URL: #2632 Reviewed-By: targos - Michaël Zasso <[email protected]> Reviewed-By: rvagg - Rod Vagg <[email protected]>
PR-URL: #2685 Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Fixes a regression that appeared with the new Buffer implementation in v3. Without this change, calling the SlowBuffer constructor with something else than a number would abort on the C++ side. This makes sure that the length argument is coerced to number or is 0. Fixes: #2634 PR-URL: #2635 Reviewed-By: trevnorris - Trevor Norris <[email protected]> Reviewed-By: cjihrig - Colin Ihrig <[email protected]>
Recursive file watching is supported by libuv since 1.7.0. Refer https://github.com/nodejs/node/blob/master/deps/uv/ChangeLog#L126. This patch notes that in the docs and enables testing this feature. It also adds proper TAP plugin parsable message for other platforms. PR-URL: #2649 Fixes: #375 Reviewed-By: rvagg - Rod Vagg <[email protected]> Reviewed-By: silverwind - Roman Reiss <[email protected]>
Long exception lines resulted in a stack buffer overflow or assertion because it was assumed snprintf not counts discarded chars or the assertion itself was incorrect: `(off) >= sizeof(arrow)` PR-URL: #2404 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
The version used before returned -1 on truncation which does not conform to the standard. PR-URL: #2404 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
- Added NODE_REPL_HISTORY to the environment variables in the --help and made all descriptions start with lower case for consistency. - Added NODE_REPL_HISTORY and NODE_ICU_DATA to the man page. PR-URL: #2690 Reviewed-By: fishrock123 - Jeremiah Senkpiel <[email protected]> Reviewed-By: evanlucas - Evan Lucas <[email protected]>
PR-URL: #2674 Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: #2687 Reviewed-By: Jeremiah Senkpiel <[email protected]>
Note: When this was cherry-picked for v8 v4.4 (landed in #2636), test-heap.cc:1989 chunk did not exist. It now exists in v8 v4.5.103.30. This PR completes the cherry pick of the whole commit from v8. PR-URL: #2692 Reviewed-By: ofrobots - Ali Ijaz Sheikh <[email protected]> Original commit message: Use static_cast<> for NULL (clang 3.7) The following errors come up when compiling v8 with clang 3.7 on FreeBSD/amd64: src/runtime/runtime-i18n.cc:629:37: error: reinterpret_cast from 'nullptr_t' to 'v8::internal::Smi *' is not allowed local_object->SetInternalField(1, reinterpret_cast<Smi*>(NULL)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ test/cctest/test-heap.cc:131:20: error: reinterpret_cast from 'nullptr_t' to 'v8::internal::Object *' is not allowed Handle<Object> n(reinterpret_cast<Object*>(NULL), isolate); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ test/cctest/test-heap.cc:1989:18: error: reinterpret_cast from 'nullptr_t' to 'Address' (aka 'unsigned char *') is not allowed Address base = reinterpret_cast<Address>(NULL); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +add myself to the AUTHORS file. BUG= Review URL: https://codereview.chromium.org/1277353002 Cr-Commit-Position: refs/heads/master@{#30103}
len and length var in timers.js are constants. Therefore, this commit replaces length,len var statements with const statements
ChALkeR
added
the
timers
|
@JungMinu Sorry, but by (possibly unstated) policy, we avoid style changes in the code or code comments. This is to keep some git tools more clear, such as Given that this doesn't actually effect the functionality (and usually neither does We will encourage updating these things if the code lines they are change for functional purposes, though. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
len and length var in timers.js are constants.
Therefore, this commit replaces length,len var statements with const statements