-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: remove "How is an LTS release cut?" section #26955
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release process is in the Release plan, linked earlier in the doc. Don't include information here because duplicated information is likely to drift apart, resulting in contradictions and a lack of clarity about which document is correct. (I think the text removed is already out-of-date. I could be wrong, and it doesn't much matter, as it should be removed anyway.) It's also not entirely clear what the utility/relevance of this information is in this particular document.
targos
approved these changes
Mar 28, 2019
vsemozhetbyt
added
the
meta
Issues and PRs related to the general management of the project.
label
Mar 28, 2019
BridgeAR
approved these changes
Mar 28, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the comment addressed.
There were two other sections that no longer exist that were still in the ToC. I've removed those as well. |
Trott
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Mar 28, 2019
apapirovski
approved these changes
Mar 28, 2019
lpinca
approved these changes
Mar 28, 2019
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 30, 2019
The release process is in the Release plan, linked earlier in the doc. Don't include information here because duplicated information is likely to drift apart, resulting in contradictions and a lack of clarity about which document is correct. (I think the text removed is already out-of-date. I could be wrong, and it doesn't much matter, as it should be removed anyway.) It's also not entirely clear what the utility/relevance of this information is in this particular document. PR-URL: nodejs#26955 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Landed in 6bc2ab1 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 5, 2019
The release process is in the Release plan, linked earlier in the doc. Don't include information here because duplicated information is likely to drift apart, resulting in contradictions and a lack of clarity about which document is correct. (I think the text removed is already out-of-date. I could be wrong, and it doesn't much matter, as it should be removed anyway.) It's also not entirely clear what the utility/relevance of this information is in this particular document. PR-URL: #26955 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 8, 2019
The release process is in the Release plan, linked earlier in the doc. Don't include information here because duplicated information is likely to drift apart, resulting in contradictions and a lack of clarity about which document is correct. (I think the text removed is already out-of-date. I could be wrong, and it doesn't much matter, as it should be removed anyway.) It's also not entirely clear what the utility/relevance of this information is in this particular document. PR-URL: #26955 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
doc
Issues and PRs related to the documentations.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release process is in (or will soon be in) the Release repo, linked earlier in the doc.
Don't include information here because duplicated information is likely
to drift apart, resulting in contradictions and a lack of clarity about
which document is correct. (I think the text removed is already
out-of-date. I could be wrong, and it doesn't much matter, as it should
be removed anyway.) It's also not entirely clear what the
utility/relevance of this information is in this particular document.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes