-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove test-path-parse-6229.js from known issues #26913
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test precedented the official documentation that states that this is an expected behavior. Refs: nodejs#6229 Refs: nodejs#12181
@nodejs/testing PTAL |
Trott
approved these changes
Mar 28, 2019
BridgeAR
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Mar 28, 2019
targos
approved these changes
Mar 29, 2019
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Mar 29, 2019
This test precedented the official documentation that states that this is an expected behavior. PR-URL: nodejs#26913 Refs: nodejs#6229 Refs: nodejs#12181 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Landed in f9da55c. |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 5, 2019
This test precedented the official documentation that states that this is an expected behavior. PR-URL: #26913 Refs: #6229 Refs: #12181 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 8, 2019
This test precedented the official documentation that states that this is an expected behavior. PR-URL: #26913 Refs: #6229 Refs: #12181 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Signed-off-by: Beth Griggs <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test precedented the official documentation that states that
this is an expected behavior.
Refs: #6229
Refs: #12181
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes