Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: document fake ENOTFOUND as a system error #26495

Merged
merged 1 commit into from
Mar 10, 2019
Merged

doc: document fake ENOTFOUND as a system error #26495

merged 1 commit into from
Mar 10, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 7, 2019

Fixes: #26484

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2799/pipeline

@nodejs-github-bot nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Mar 7, 2019
richardlau
richardlau approved these changes Mar 7, 2019
View reviewed changes
doc/api/errors.md Outdated Show resolved Hide resolved
@BridgeAR
Copy link
Member

BridgeAR commented Mar 8, 2019

Lite CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2813/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2019
@cjihrig
doc: document fake ENOTFOUND as a system error
3194744 
PR-URL: nodejs#26495
Fixes: nodejs#26484
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@cjihrig cjihrig merged commit 3194744 into nodejs:master Mar 10, 2019
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@cjihrig @BridgeAR
doc: document fake ENOTFOUND as a system error
7122a3f 
PR-URL: #26495
Fixes: #26484
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
BridgeAR pushed a commit that referenced this pull request Mar 13, 2019
@cjihrig @BridgeAR
doc: document fake ENOTFOUND as a system error
f91dab6 
PR-URL: #26495
Fixes: #26484
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@cjihrig @BridgeAR
doc: document fake ENOTFOUND as a system error
414ad11 
PR-URL: #26495
Fixes: #26484
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. errors Issues and PRs related to JavaScript errors originated in Node.js core.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @nodejs-github-bot @BridgeAR @jasnell @Trott @addaleax @gengjiawen @richardlau