Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: simplify GetPublicOrPrivateKeyFromJs #26454

Closed
wants to merge 1 commit into from
Closed

crypto: simplify GetPublicOrPrivateKeyFromJs #26454

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Mar 5, 2019

The last argument is now always set to true due to #26278. This change removes said argument and its only usage in an assertion.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2769/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Mar 5, 2019
bnoordhuis
bnoordhuis approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I felt it should have been an enum in the first place. :-)

@BridgeAR
Copy link
Member

BridgeAR commented Mar 5, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/21236/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2019
@shisama
Copy link
Contributor

shisama commented Mar 6, 2019

Resume build: https://ci.nodejs.org/job/node-test-pull-request/21247/

@tniessen
Copy link
Member Author

tniessen commented Mar 6, 2019

Resume build: https://ci.nodejs.org/job/node-test-pull-request/21261/

@tniessen
Copy link
Member Author

tniessen commented Mar 7, 2019

Thanks for reviewing, everyone! Landed in 3e4e518.

@tniessen tniessen closed this Mar 7, 2019
tniessen added a commit that referenced this pull request Mar 7, 2019
@tniessen
crypto: simplify GetPublicOrPrivateKeyFromJs
3e4e518 
PR-URL: #26454
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@tniessen @BridgeAR
crypto: simplify GetPublicOrPrivateKeyFromJs
ab1327f 
PR-URL: nodejs#26454
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@tniessen @BridgeAR
crypto: simplify GetPublicOrPrivateKeyFromJs
991ea8a 
PR-URL: #26454
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
@tniessen tniessen mentioned this pull request Mar 15, 2019
Closed
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shisama shisama shisama approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tniessen @nodejs-github-bot @BridgeAR @shisama @bnoordhuis @jasnell @addaleax @lpinca