Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test/report/test-report-signal.js #26446

Merged
merged 1 commit into from
Mar 7, 2019
Merged

test: refactor test/report/test-report-signal.js #26446

merged 1 commit into from
Mar 7, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 5, 2019

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2763/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 5, 2019
mhdawson
mhdawson approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR
Copy link
Member

BridgeAR commented Mar 5, 2019

@cjihrig this needs a rebase.

@cjihrig cjihrig force-pushed the test branch 2 times, most recently from 05892e8 to 71dcf29 Compare March 7, 2019 18:59
@cjihrig
test: refactor test/report/test-report-signal.js
c1a9c50 
PR-URL: nodejs#26446
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 7, 2019

Green CI: https://ci.nodejs.org/job/node-test-pull-request/21314/

@cjihrig cjihrig merged commit c1a9c50 into nodejs:master Mar 7, 2019
@cjihrig cjihrig deleted the test branch March 7, 2019 20:49
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@cjihrig @BridgeAR
test: refactor test/report/test-report-signal.js
d1c225f 
PR-URL: nodejs#26446
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@cjihrig @BridgeAR
test: refactor test/report/test-report-signal.js
153a29c 
PR-URL: #26446
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shisama shisama shisama approved these changes

@mhdawson mhdawson mhdawson approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @nodejs-github-bot @BridgeAR @jasnell @richardlau @BethGriggs @mhdawson @shisama