Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: refactor configuration management #26414

Merged
merged 2 commits into from
Mar 5, 2019
Merged

report: refactor configuration management #26414

merged 2 commits into from
Mar 5, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Mar 3, 2019

This commit removes process.report.setOptions(). Instead of using complex configuration synchronization between C++ and JS, this commit introduces individual getters and setters.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2750/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Mar 3, 2019
richardlau
richardlau reviewed Mar 3, 2019
View reviewed changes
doc/api/process.md Outdated Show resolved Hide resolved
test/report/test-report-config.js Outdated Show resolved Hide resolved
test/report/test-report-config.js Outdated Show resolved Hide resolved
@richardlau richardlau added the report Issues and PRs related to process.report. label Mar 3, 2019
@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 5, 2019

@richardlau @jasnell nits addressed

richardlau
richardlau approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion and once the test is fixed for Windows.

lib/internal/process/report.js Outdated Show resolved Hide resolved
test/report/test-report-config.js Outdated Show resolved Hide resolved
@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 5, 2019

@richardlau @jasnell nits addressed (again)

@richardlau
Copy link
Member

There are some C++ linter failures:

https://travis-ci.com/nodejs/node/jobs/182405108#L457-L462

Running C++ linter...
File "src/node_report_module.cc" does not use "FIXED_ONE_BYTE_STRING"
File "src/node_report_module.cc" does not use "PerIsolateOptions"
File "src/node_report_module.cc" does not use "Array"
File "src/node_report_module.cc" does not use "V8"
make[1]: *** [tools/.cpplintstamp] Error 1

@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 5, 2019

OK, Travis seems to be happy now.

@cjihrig
report: refactor configuration management
30ee277 
This commit removes process.report.setOptions(). Instead of
using complex configuration synchronization between C++ and
JS, this commit introduces individual getters and setters.

PR-URL: nodejs#26414
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Wyatt Preul <[email protected]>
@cjihrig
report: warn on process.report object access
cc4e8e0 
Reduce the number of emitExperimentalWarning() call sites by
making process.report emit a warning on access instead of each
individual report function.

PR-URL: nodejs#26414
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Wyatt Preul <[email protected]>
@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 5, 2019

Yellow CI: https://ci.nodejs.org/job/node-test-pull-request/21216/

@cjihrig
Copy link
Contributor Author

cjihrig commented Mar 5, 2019

Landed in c78788a...cc4e8e0. Thanks for the reviews!

@cjihrig cjihrig closed this Mar 5, 2019
@cjihrig cjihrig deleted the sync branch March 5, 2019 20:37
@cjihrig cjihrig merged commit cc4e8e0 into nodejs:master Mar 5, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@cjihrig @BridgeAR
report: refactor configuration management
9f446a1 
This commit removes process.report.setOptions(). Instead of
using complex configuration synchronization between C++ and
JS, this commit introduces individual getters and setters.

PR-URL: nodejs#26414
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Wyatt Preul <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@cjihrig @BridgeAR
report: warn on process.report object access
2be9e80 
Reduce the number of emitExperimentalWarning() call sites by
making process.report emit a warning on access instead of each
individual report function.

PR-URL: nodejs#26414
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Wyatt Preul <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell left review comments

@richardlau richardlau richardlau approved these changes

@geek geek geek approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjihrig @nodejs-github-bot @richardlau @jasnell @geek