Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: clean up MultiIsolatePlatform interface #26384

Closed
wants to merge 1 commit into from
Closed

src: clean up MultiIsolatePlatform interface #26384

wants to merge 1 commit into from
+59 −37

Commits on Mar 9, 2019

  1. src: clean up MultiIsolatePlatform interface 

    - Since this was introduced, V8 has effectively started requiring
  that the platform knows of the `Isolate*` before we (or an embedder)
  create our `IsolateData` structure; therefore, (un)registering it
  from the `IsolateData` constructor/destructor doesn’t make much
  sense anymore.
- Instead, we can require that the register/unregister functions
  are only called once, simplifying the implementation a bit.
- Add a callback that we can use to know when the platform has
  cleaned up its resources associated with a given `Isolate`.
  In particular, this means that in the Worker code, we don’t need
  to rely on what are essentially guesses about the number of event
  loop turns that we need in order to have everything cleaned up.
    @addaleax
    addaleax committed Mar 9, 2019
    Configuration menu
    Copy the full SHA
    afba46a View commit details
    Browse the repository at this point in the history