Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: use latest rather than next for markdown linting plugin #26345

Closed
wants to merge 2 commits into from
Closed

tools: use latest rather than next for markdown linting plugin #26345

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 28, 2019

First commit:

tools: use latest rather than next for markdown linting plugin

eslint-plugin-markdown is being installed @next to get a bugfix for
https://github.com/eslint/eslint-plugin-markdown/issues/69 but that
bugfix is in 1.0.0. Go back to installing @latest rather than @next.

Second commit:

tools: update eslint-plugin-markdown to 1.0.0

For eslint-plugin-markdown, we had been using an RC but can now use the
most recent stable release of 1.0.0, as it has the bugfix that caused us
to start using the RC in the first place.

There are a few other updates in this commit too because it was
performed by running `update-eslint.sh`. This did not update ESLint
itself but did update some dependencies.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Trott added 2 commits February 27, 2019 22:29
@Trott
tools: use latest rather than next for markdown linting plugin
48747d4 
eslint-plugin-markdown is being installed @next to get a bugfix for
eslint/markdown#69 but that
bugfix is in 1.0.0. Go back to installing @latest rather than @next.
@Trott
tools: update eslint-plugin-markdown to 1.0.0
1d61eaa 
For eslint-plugin-markdown, we had been using an RC but can now use the
most recent stable release of 1.0.0, as it has the bugfix that caused us
to start using the RC in the first place.

There are a few other updates in this commit too because it was
performed by running `update-eslint.sh`. This did not update ESLint
itself but did update some dependencies.
@nodejs-github-bot
Copy link
Collaborator

@Trott sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 28, 2019
@Trott
Copy link
Member Author

Trott commented Feb 28, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2710/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 28, 2019
@Trott
Copy link
Member Author

Trott commented Mar 2, 2019

Landed in 144f876...f11e8b9

@Trott Trott closed this Mar 2, 2019
Trott added a commit to Trott/io.js that referenced this pull request Mar 2, 2019
@Trott
tools: use latest rather than next for markdown linting plugin
e0c3921 
eslint-plugin-markdown is being installed @next to get a bugfix for
eslint/markdown#69 but that
bugfix is in 1.0.0. Go back to installing @latest rather than @next.

PR-URL: nodejs#26345
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Mar 2, 2019
@Trott
tools: update eslint-plugin-markdown to 1.0.0
f11e8b9 
For eslint-plugin-markdown, we had been using an RC but can now use the
most recent stable release of 1.0.0, as it has the bugfix that caused us
to start using the RC in the first place.

There are a few other updates in this commit too because it was
performed by running `update-eslint.sh`. This did not update ESLint
itself but did update some dependencies.

PR-URL: nodejs#26345
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 2, 2019
@Trott @addaleax
tools: use latest rather than next for markdown linting plugin
adcbcf5 
eslint-plugin-markdown is being installed @next to get a bugfix for
eslint/markdown#69 but that
bugfix is in 1.0.0. Go back to installing @latest rather than @next.

PR-URL: #26345
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
addaleax pushed a commit that referenced this pull request Mar 2, 2019
@Trott @addaleax
tools: update eslint-plugin-markdown to 1.0.0
347dd99 
For eslint-plugin-markdown, we had been using an RC but can now use the
most recent stable release of 1.0.0, as it has the bugfix that caused us
to start using the RC in the first place.

There are a few other updates in this commit too because it was
performed by running `update-eslint.sh`. This did not update ESLint
itself but did update some dependencies.

PR-URL: #26345
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
@Trott Trott deleted the update-update branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @nodejs-github-bot @cjihrig @richardlau @BridgeAR