report: fix build warning in node_report.cc

[richardlau]

Fixes the following build warning:

CXX(target) /home/travis/build/nodejs/node/out/Release/obj.target/node_lib/src/node_report.o
../src/node_report.cc: In function ‘std::string report::TriggerNodeReport(v8::Isolate*, node::Environment*, const char*, const char*, std::string, v8::Local<v8::String>)’:
../src/node_report.cc:184:76: warning: ‘outstream’ may be used uninitialized in this function [-Wmaybe-uninitialized]
       isolate, env, message, location, filename, out, stackstr, &tm_struct);
                                                                            ^
../src/node_report.cc:149:17: note: ‘outstream’ was declared here
   std::ostream* outstream;
                 ^

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@richardlau sadly an error occured when I tried to trigger a build :(

[richardlau]

CI will need to wait until the lockdown ends.

[Trott]

CI looks quiescent right now, so here you go: https://ci.nodejs.org/job/node-test-pull-request/20971/

Not sure if the GitHub widget will still report results or if someone with access will have to let you know if it passed or not.

[richardlau]

CI looks quiescent right now, so here you go: https://ci.nodejs.org/job/node-test-pull-request/20971/

Not sure if the GitHub widget will still report results or if someone with access will have to let you know if it passed or not.

The status is being posted, so the widget is showing results. node-test-commit-windows-fanned failed -- if anyone has access could comment on whether the failure looks related to this PR (in which case please post the relevant log) or some flake/infra issue.

FTR I'm in no particular rush to land this.

[Trott]

@richardlau The Windows failure is a pervasive infra-related thing. If you're in no rush, once it's fixed, we can do a quick Resume Build.

[Trott]

I think @refack fixed stuff. 🎉 Here's a Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20972/

[richardlau]

Rebased based on irc chat suggestions that the Windows issue is #25593 and that recent commits to master may have mitigated it.

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/20974/

I don't think it's been fixed yet, but I'll be happy to be wrong....

[mhdawson]

LGTM

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/21008/

[richardlau]

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/21031/ (✔️)

[richardlau]

Landed in 4a10ce6.