build: silence cpp lint by default #26252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
danbev
suggested changes
Feb 22, 2019
The cpp linter is very noisy at the moment. So use the --quiet flag by default instead of being verbose in this case.
BridgeAR
force-pushed
the
silence-lint-cpp
branch
from
abf4806
to
78e4a79
Compare
danbev
approved these changes
Feb 25, 2019
jasnell
approved these changes
Feb 25, 2019
BridgeAR
added
the
author ready
|
Landed in 0373836 🎉 |
BridgeAR
added a commit
to BridgeAR/node
that referenced
this pull request
Feb 28, 2019
The cpp linter is very noisy at the moment. So use the --quiet flag by default instead of being verbose in this case. PR-URL: nodejs#26252 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Mar 1, 2019
The cpp linter is very noisy at the moment. So use the --quiet flag by default instead of being verbose in this case. PR-URL: #26252 Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
2 tasks
refack
added a commit
to refack/node
that referenced
this pull request
Mar 22, 2019
PR-URL: nodejs#26740 Refs: nodejs#26252 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cpp linter is very noisy at the moment. So use the --quiet flag
by default instead of being verbose in this case.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes