Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: revise deprecation semverness info in Collaborator Guide #26232

Closed
wants to merge 2 commits into from
Closed

doc: revise deprecation semverness info in Collaborator Guide #26232

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64f7b9c
doc: revise deprecation semverness info in Collaborator Guide
Trott Feb 21, 2019
9152145
squash: Apply suggestions from code review
vsemozhetbyt Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions COLLABORATOR_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,13 +339,13 @@ documentation must state the deprecation status.
* Backward-incompatible changes including complete removal of such APIs may
occur at any time.

Documentation-Only Deprecations may be handled as semver-minor or semver-major
changes. Such deprecations have no impact on the successful operation of running
code and therefore should not be viewed as breaking changes.
Apply the `notable change` label to all pull requests that introduce
Documentation-Only Deprecations. Such deprecations have no impact on code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK we try to add the label to all deprecations - no matter if it's doc-only, runtime or end-of-life.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and that's noted on line 371 currently. I'm repeating it here though because Documentation-Only deprecations are the ones most likely to be missed as notable changes. Other ones go in as semver-major so they're likely to be noticed.

execution. Thus, they are not breaking changes (`semver-major`).

Runtime Deprecations and End-of-life APIs (internal or public) must be
handled as semver-major changes unless there is TSC consensus to land the
deprecation as a semver-minor.
Runtime Deprecations and End-of-life APIs (internal or public) are breaking
changes (`semver-major`) . The TSC may make exceptions, deciding that one of
Trott marked this conversation as resolved.
Show resolved Hide resolved
these deprecations is not a breaking change.

All Documentation-Only and Runtime deprecations will be assigned a unique
identifier that can be used to persistently refer to the deprecation in
Expand Down