Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor to make flaky test robust #2609

Closed
wants to merge 1 commit into from
Closed

test: refactor to make flaky test robust #2609

wants to merge 1 commit into from

Commits on Sep 3, 2015

  1. test: refactor to eliminate flaky test 

    This retains the key elements of test-child-process-fork-getconnections
(forks a child process, sends a bunch of sockets, uses getConnections()
to enumerate them) but contains some code to work around an apparent
intermittent bug that occurs on OS X where a socket seems to close
itself unexpectedly.

nodejs#2610 was opened for the bug that
was causing the problem in the first place.

PR-URL: nodejs#2609
Fixes: nodejs#1100
    @Trott
    Trott committed Sep 3, 2015
    Configuration menu
    Copy the full SHA
    a52feab View commit details
    Browse the repository at this point in the history