[v11.x backport] tools: update ESLint to 5.13.0 and replace deprecated configuration #25965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 2.1.0 of dmn will get rid of .map and .ts files.
For `globals`, booleans are deprecated in favor strings `'readable'`/`'writeable'`.
nodejs-github-bot
added
tools
2 tasks
|
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20626/ |
|
Okay, maybe not a good time. But any thought on #25908 (comment) ? |
addaleax
approved these changes
Feb 7, 2019
|
@gengjiawen Yeah, this PR is only about backporting commits from master … let’s keep that discussion in the issue you linked :) |
|
Landed in e81c6c8...c55d662, thanks for the backport! |
addaleax
pushed a commit
that referenced
this pull request
Feb 7, 2019
Version 2.1.0 of dmn will get rid of .map and .ts files. Backport-PR-URL: #25965 PR-URL: #25877 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Feb 7, 2019
Backport-PR-URL: #25965 PR-URL: #25877 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
addaleax
pushed a commit
that referenced
this pull request
Feb 7, 2019
For `globals`, booleans are deprecated in favor strings `'readable'`/`'writeable'`. Backport-PR-URL: #25965 PR-URL: #25877 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #25877