Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix data type in node_crypto.cc #25889

Closed
wants to merge 1 commit into from
Closed

src: fix data type in node_crypto.cc #25889

wants to merge 1 commit into from

Conversation

gengjiawen
Copy link
Member

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Feb 2, 2019
@danbev
Copy link
Contributor

danbev commented Feb 5, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/20580/

@danbev
Copy link
Contributor

danbev commented Feb 6, 2019

Landed in d3ea639.

@danbev danbev closed this Feb 6, 2019
dnalborczyk pushed a commit to dnalborczyk/node that referenced this pull request Feb 6, 2019
@gengjiawen @danbev
src: fix data type in node_crypto.cc
d3ea639 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: nodejs#25889
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
addaleax pushed a commit that referenced this pull request Feb 6, 2019
@gengjiawen @addaleax
src: fix data type in node_crypto.cc
5a66e38 
Signed-off-by: gengjiawen <[email protected]>

PR-URL: #25889
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daniel Bevenius <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Feb 14, 2019
Merged
This was referenced Feb 15, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gengjiawen @danbev @jasnell @addaleax @cjihrig @nodejs-github-bot