meta: update note about building on smartOS 16 #25684
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
The same note is in Node.js 10. We can't currently run the prebuilt Node.js 10 binaries on SmartOS 16 on the CI: nodejs/build#1519 |
Trott
approved these changes
Feb 17, 2019
jasnell
approved these changes
Feb 18, 2019
Trott
added
the
author ready
BridgeAR
approved these changes
Feb 20, 2019
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 4, 2019
PR-URL: nodejs#25684 Refs: nodejs#25683 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
|
Landed in 000788e 🎉 |
BridgeAR
pushed a commit
that referenced
this pull request
Mar 4, 2019
PR-URL: #25684 Refs: #25683 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Mar 5, 2019
PR-URL: #25684 Refs: #25683 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like note is outdated. ATM we run CI tests on smartOS 16 with GCC 4.9
https://github.com/nodejs/build/blob/383c09339779cb46a32c47909ed3cee3a1850001/ansible/roles/baselayout/vars/main.yml#L91-L94
and on smartOS17 with GCC7.
https://github.com/nodejs/build/blob/383c09339779cb46a32c47909ed3cee3a1850001/jenkins/scripts/VersionSelectorScript.groovy#L43-L48
I'm not sure if this note needs updating or complete removal.
/CC @nodejs/platform-smartos @nodejs/build
Refs: #25683
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes