Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: represent numbers as numbers #25651

Closed
wants to merge 2 commits into from
Closed

report: represent numbers as numbers #25651

wants to merge 2 commits into from

Conversation

addaleax
Copy link
Member

report: refactor JSON writer

  • Support non-string entry types
  • Prefer single-character writes over string writes
  • Rename the state constants and adjust style to match more common Node.js style

report: represent numbers as numbers

Do not stringify numbers and boolean values when writing JSON.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@addaleax
report: refactor JSON writer
37c4f05 
- Support non-string entry types
- Prefer single-character writes over string writes
- Rename the state constants and adjust style to match more
  common Node.js style
@addaleax
report: represent numbers as numbers
ee1b9ce 
Do not stringify numbers and boolean values when writing JSON.
@addaleax addaleax added the report Issues and PRs related to process.report. label Jan 22, 2019
@nodejs-github-bot
Copy link
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2347/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jan 22, 2019
@addaleax
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/20296/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 24, 2019
@addaleax
Copy link
Member Author

Resume CI: https://ci.nodejs.org/job/node-test-pull-request/20309/

mhdawson
mhdawson approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addaleax
Copy link
Member Author

Resume CI again: https://ci.nodejs.org/job/node-test-pull-request/20332/

@addaleax
Copy link
Member Author

Again: https://ci.nodejs.org/job/node-test-pull-request/20349/

@addaleax
Copy link
Member Author

Sigh… let’s try a fresh full CI: https://ci.nodejs.org/job/node-test-pull-request/20353/

@addaleax
Copy link
Member Author

Landed in 08e9111, accd674

@addaleax addaleax closed this Jan 27, 2019
@addaleax addaleax deleted the report-numbers branch January 27, 2019 19:40
addaleax added a commit that referenced this pull request Jan 27, 2019
@addaleax
report: refactor JSON writer
08e9111 
- Support non-string entry types
- Prefer single-character writes over string writes
- Rename the state constants and adjust style to match more
  common Node.js style

PR-URL: #25651
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
addaleax added a commit that referenced this pull request Jan 27, 2019
@addaleax
report: represent numbers as numbers
accd674 
Do not stringify numbers and boolean values when writing JSON.

PR-URL: #25651
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
addaleax added a commit that referenced this pull request Jan 28, 2019
@addaleax
report: refactor JSON writer
1dfdbc6 
- Support non-string entry types
- Prefer single-character writes over string writes
- Rename the state constants and adjust style to match more
  common Node.js style

PR-URL: #25651
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
addaleax added a commit that referenced this pull request Jan 28, 2019
@addaleax
report: represent numbers as numbers
ce28caf 
Do not stringify numbers and boolean values when writing JSON.

PR-URL: #25651
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matheus Marchini <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@targos targos mentioned this pull request Jan 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@mmarchini mmarchini mmarchini approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@addaleax @nodejs-github-bot @cjihrig @mmarchini @richardlau @gireeshpunathil @BethGriggs @mhdawson