-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: running coverage for individual suites #25622
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoe
added
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
labels
Jan 21, 2019
nodejs-github-bot
added
the
build
Issues and PRs related to build files or the CI.
label
Jan 21, 2019
mhdawson
approved these changes
Jan 21, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@vsemozhetbyt added the additional ticks, also noticed the paragraph below was a bit redundant and reworded. If folks are alright with this pass at the documentation, I'm advocating this doc change is probably okay to fast track. |
vsemozhetbyt
approved these changes
Jan 22, 2019
thefourtheye
approved these changes
Jan 22, 2019
bcoe
force-pushed
the
run-isolated-suites
branch
from
January 22, 2019 20:15
a577e27
to
f598618
Compare
Landed in 885b3bc |
bcoe
added a commit
to bcoe/node-1
that referenced
this pull request
Jan 23, 2019
PR-URL: nodejs#25622 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Landed in e3f917e |
addaleax
pushed a commit
that referenced
this pull request
Jan 23, 2019
PR-URL: #25622 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Issues and PRs related to build files or the CI.
doc
Issues and PRs related to the documentations.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up from d1dee49, adding @thefourtheye's documentation request.
Checklist