Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: simplify inspector initialization in node::Start() #25612

Closed
wants to merge 1 commit into from
Closed

src: simplify inspector initialization in node::Start() #25612

wants to merge 1 commit into from

Commits on Jan 21, 2019

  1. src: simplify inspector initialization in node::Start() 

    Remove the `StartInspector` and `InspectorStarted` abstraction
out of `v8_platform`, and error out early and directly in the
option parser if Node is configured with NODE_USE_V8_PLATFORM and
inspector enabled but the user still tries to use inspector options.
    @joyeecheung
    joyeecheung committed Jan 21, 2019
    Configuration menu
    Copy the full SHA
    a1ad0ec View commit details
    Browse the repository at this point in the history