worker: Fix workers isolation #25196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignoring the connection header and disable the `ERR_HTTP2_INVALID_CONNECTION_HEADERS` error. Added a warning log on the compatibility. Fixes: nodejs#23748
|
@nodejs/workers |
Refs: nodejs#23277 PR-URL: nodejs#25042 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
WPT covers standards in both W3C and WHATWG, as such it would be strange to make this disparity explicit in our file names (e.g. when testing standards that are solely in W3C, like performance-timeline). Remove the reference to WHATWG will also make the file names shorter. PR-URL: nodejs#24826 Refs: nodejs#24823 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
This patch: - Support wildcards(*) in WPT runner name matching (needed by e.g. encoding where all the tests requires i18n support in the build) - Print failure reasons when encountering an expected failure - Fix a bug in copyGlobalsFromObject (previously it copies properties from `global` instead of the given `obj`) Previously an expected failure is printed as ``` [EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D= ``` Now it is printed as ``` [EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D= missing Request and Response ``` PR-URL: nodejs#24826 Refs: nodejs#24823 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
Refs: # nodejs#25033 PR-URL: nodejs#25050 Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
Refs: nodejs#25029 PR-URL: nodejs#25051 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`
PR-URL: nodejs#24962
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Most people are going to use the existing option and switching the name now comes with a cost which does not seem to justify the improvement. PR-URL: nodejs#24982 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: nodejs#24843 Refs: nodejs#24385 Reviewed-By: Ruben Bridgewater <[email protected]>
Added strict mode inside the worker script. Fixes: nodejs#24947
sagitsofan
force-pushed
the
worker-isolation
branch
from
c5ac863 to
df68413
Compare
|
@sagitsofan please remove not your commits from PR and squash yours |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib: worker fix workers isolation
Added strict mode inside the worker script.
Fixes: #24947
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes