Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

worker: Fix workers isolation #25196

Closed
wants to merge 12 commits into from

Conversation

sagitsofan
Copy link
Contributor

@sagitsofan sagitsofan commented Dec 23, 2018

lib: worker fix workers isolation

Added strict mode inside the worker script.

Fixes: #24947

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Ignoring the connection header and disable the
`ERR_HTTP2_INVALID_CONNECTION_HEADERS` error.

Added a warning log on the compatibility.

Fixes: nodejs#23748
@nodejs-github-bot nodejs-github-bot added the worker Issues and PRs related to Worker support. label Dec 23, 2018
@sagitsofan sagitsofan changed the title lib: Fix workers isolation worker: Fix workers isolation Dec 23, 2018
@Trott
Copy link
Member

Trott commented Dec 23, 2018

@nodejs/workers

Trott and others added 11 commits December 24, 2018 08:52
Refs: nodejs#23277

PR-URL: nodejs#25042
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
WPT covers standards in both W3C and WHATWG, as such it would be
strange to make this disparity explicit in our file names
(e.g. when testing standards that are solely in W3C, like
performance-timeline). Remove the reference to WHATWG will
also make the file names shorter.

PR-URL: nodejs#24826
Refs: nodejs#24823
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
This patch:

- Support wildcards(*) in WPT runner name matching (needed by e.g.
  encoding where all the tests requires i18n support in the build)
- Print failure reasons when encountering an expected failure
- Fix a bug in copyGlobalsFromObject (previously it copies
  properties from `global` instead of the given `obj`)

Previously an expected failure is printed as

```
[EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D=
```

Now it is printed as

```
[EXPECTED_FAILURE] response.formData() with input: %61+%4d%4D=
missing Request and Response
```

PR-URL: nodejs#24826
Refs: nodejs#24823
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Refs: # nodejs#25033

PR-URL: nodejs#25050
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Refs: nodejs#25029

PR-URL: nodejs#25051
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Instead use
`require('internal/options').getOptionValue('--pending-deprecation')`

PR-URL: nodejs#24962
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Most people are going to use the existing option and switching the
name now comes with a cost which does not seem to justify the
improvement.

PR-URL: nodejs#24982
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Added strict mode inside the worker script.

Fixes: nodejs#24947
@sagitsofan sagitsofan closed this Dec 24, 2018
@sagitsofan sagitsofan deleted the worker-isolation branch December 24, 2018 06:57
@tshemsedinov
Copy link
Contributor

@sagitsofan please remove not your commits from PR and squash yours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
worker Issues and PRs related to Worker support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(experimental) worker isolation
7 participants