Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release proposal: v3.2.0 #2511

Closed
wants to merge 74 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
74 commits
Select commit Hold shift + click to select a range
0bb099f
build: expand ~ in install prefix early
bnoordhuis Aug 5, 2015
e76822f
doc: multiple documentation updates cherry picked from v0.12
jasnell Jun 24, 2015
cf9ba81
test: address timing issues in simple http tests
gireeshpunathil Mar 18, 2015
1738c96
net: ensure Socket reported address is current
rmg Jul 2, 2015
0ee4df9
test: make listen-fd-cluster/server more robust
sam-github Jun 10, 2015
e83a41a
tls: introduce internal `onticketkeycallback`
indutny Aug 8, 2015
94b765f
tls: fix check for reused session
indutny Aug 8, 2015
7606bdb
util: display constructor when inspecting objects
monsanto Jun 10, 2015
07a88b0
build: update manifest to include Windows 10
LPGhatguy Aug 9, 2015
7118b8a
path: remove dead code in favor of unit tests
nwoltman Jul 31, 2015
cc46d3b
test: clarify dropMembership() call
Trott Jun 26, 2015
ccf12df
src: add total_available_size to v8 statistics
r-52 Aug 11, 2015
e51f90d
test: option to run a subset of tests
joaocgreis Jul 27, 2015
071640a
build: Intl: bump ICU4C from 54 to 55
srl295 Aug 3, 2015
1f12e03
build: intl: converge from joyent/node
srl295 Aug 13, 2015
bff9bcd
src: plug memory leaks
bnoordhuis Aug 7, 2015
5586cec
src: move internal functions out of node_buffer.h
bnoordhuis Aug 13, 2015
fd63e1c
src: introduce internal Buffer::Copy() function
bnoordhuis Aug 13, 2015
455ec57
src: rename Buffer::Use() to Buffer::New()
bnoordhuis Aug 13, 2015
3645dc6
build: work around VS2015 issue in ICU <56
srl295 Jul 31, 2015
d1307b2
src: don't use fopen() in require() fast path
bnoordhuis Aug 13, 2015
844d3f0
path: use '===' instead of '==' for comparison
Aug 15, 2015
a3160c0
test: correct spelling of 'childProcess'
muddletoes Nov 12, 2014
b196c1d
src: fix memory leak in DLOpen
skomski Aug 14, 2015
f45487c
crypto: fix memory leak in SetDHParam
skomski Aug 14, 2015
a760a87
crypto: fix memory leak in SafeX509ExtPrint
skomski Aug 14, 2015
6a16368
crypto: fix memory leak in PublicKeyCipher::Cipher
skomski Aug 14, 2015
ba6eb8a
crypto: fix memory leak in ECDH::SetPrivateKey
skomski Aug 14, 2015
605f6ee
crypto: fix memory leak in PBKDF2Request
skomski Aug 14, 2015
fb0f5d7
tools: run the tick processor without building v8
Jul 1, 2015
cbb75c4
tls: fix throughput issues after incorrect merge
indutny Aug 14, 2015
7fe6dd8
crypto: check for OpenSSL errors when signing
pmq20 Aug 18, 2015
34f2cfa
src: better error message on failed Buffer malloc
skomski Aug 17, 2015
850c794
test: refactor test-fs-watchfile.js
Trott Aug 15, 2015
6483bc2
doc: clarify options for fs.watchFile()
Trott Aug 18, 2015
46cdb2f
test: lint addon tests
bnoordhuis Aug 18, 2015
194eeb8
test: drop Isolate::GetCurrent() from addon tests
bnoordhuis Aug 18, 2015
2ff183d
Update FIPS instructions in README.md
mhdawson Jul 30, 2015
53596fd
2015-08-18 io.js v3.1.0 Release
Fishrock123 Aug 18, 2015
8576324
Working on v3.1.1
Fishrock123 Aug 18, 2015
3e6a6fc
events: deprecate static listenerCount function
thefourtheye Aug 11, 2015
11d1b8f
test: improve test-net-pingpong
brendanashworth Aug 18, 2015
b60e690
test: improve test-net-server-pause-on-connect
brendanashworth Aug 18, 2015
3545e23
test: reduce timeouts in test-net-keepalive
brendanashworth Aug 18, 2015
2d3f09b
stream_base: various improvements
indutny Aug 11, 2015
7f02443
repl: dont throw ENOENT on NODE_REPL_HISTORY_FILE
toddself Aug 19, 2015
3579f3a
test: disallow unreachable code
targos Aug 20, 2015
e714b56
test: remove unreachable code
targos Aug 2, 2015
3f821b9
doc: fix spelling mistake in node.js comment
YafahEdelman Aug 15, 2015
d9b70f9
tls: handle empty cert in checkServerIndentity
Aug 10, 2015
77075ec
crypto: fix mem {de}allocation in ExportChallenge
skomski Aug 12, 2015
f5cf24a
doc: add TSC meeting minutes 2015-07-22
rvagg Aug 19, 2015
56a2ae9
src: improve startup time
evanlucas Aug 21, 2015
c1ce423
string_bytes: fix unaligned write in UCS2
indutny Aug 20, 2015
1cd794f
buffer: reapply 07c0667
indutny Aug 21, 2015
5d74869
repl: filter integer keys from repl tab complete list
jasnell Aug 17, 2015
87a9ef0
doc: add audio recording links to TSC meeting minutes
rvagg Aug 20, 2015
14f2aee
doc: fix links to original gh issues for TSC meetings
rvagg Aug 20, 2015
7130b4c
doc: fix links to original converged repo
rvagg Aug 20, 2015
51ef910
doc: add TSC meeting minutes 2015-06-03
rvagg Aug 20, 2015
aaefde7
doc: add TSC meeting minutes 2015-08-19
rvagg Aug 20, 2015
2c7b925
doc: add TSC meeting minutes 2015-07-29
rvagg Aug 19, 2015
cd0c362
doc: update AUTHORS list
rvagg Aug 6, 2015
64a8f30
tools: fix anchors in generated documents
thefourtheye Aug 22, 2015
023386c
fs: replace bad_args macro with concrete error msg
romankl Aug 22, 2015
5df06fd
test: add spaces after keywords
brendanashworth Aug 18, 2015
b76b919
tools: enable space-after-keywords in eslint
brendanashworth Aug 18, 2015
7f23a83
doc: update AUTHORS list
rvagg Aug 23, 2015
c9867fe
doc: document response.finished in http.markdown
liveinjs Dec 10, 2013
5fef5c6
tls: add --tls-cipher-list command line switch
jasnell Aug 17, 2015
4f8e34c
tools: add license boilerplate to check-imports.sh
jasnell Aug 15, 2015
09437e0
doc: fix comments in tls_wrap.cc and _http_client.js
JungMinu Aug 22, 2015
536c3d0
test: use reserved IP in test-net-connect-timeout
Trott Jul 28, 2015
23d525e
2015-08-24 io.js v3.2.0 Release
rvagg Aug 23, 2015
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: move internal functions out of node_buffer.h
The circular dependency problem that put them there in the first place
is no longer an issue.  Move them out of the public node_buffer.h header
and into the private node_internals.h header.

Fixes: #2308
PR-URL: #2352
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Trevor Norris <[email protected]>
bnoordhuis authored and rvagg committed Aug 17, 2015
commit 5586ceca1329c31363df1bcdbbc137980eda5b0a
22 changes: 0 additions & 22 deletions src/node_buffer.h
Original file line number Diff line number Diff line change
@@ -4,10 +4,6 @@
#include "node.h"
#include "v8.h"

#if defined(NODE_WANT_INTERNALS)
#include "env.h"
#endif // defined(NODE_WANT_INTERNALS)

namespace node {
namespace Buffer {

@@ -63,24 +59,6 @@ static inline bool IsWithinBounds(size_t off, size_t len, size_t max) {
return true;
}

// Internal. Not for public consumption. We can't define these
// in src/node_internals.h because of a circular dependency.
#if defined(NODE_WANT_INTERNALS)
v8::MaybeLocal<v8::Object> New(Environment* env, size_t size);
// Makes a copy of |data|.
v8::MaybeLocal<v8::Object> New(Environment* env, const char* data, size_t len);
// Takes ownership of |data|.
v8::MaybeLocal<v8::Object> New(Environment* env,
char* data,
size_t length,
FreeCallback callback,
void* hint);
// Takes ownership of |data|. Must allocate |data| with malloc() or realloc()
// because ArrayBufferAllocator::Free() deallocates it again with free().
// Mixing operator new and free() is undefined behavior so don't do that.
v8::MaybeLocal<v8::Object> Use(Environment* env, char* data, size_t length);
#endif // defined(NODE_WANT_INTERNALS)

} // namespace Buffer
} // namespace node

16 changes: 16 additions & 0 deletions src/node_internals.h
Original file line number Diff line number Diff line change
@@ -272,6 +272,22 @@ class NodeInstanceData {
DISALLOW_COPY_AND_ASSIGN(NodeInstanceData);
};

namespace Buffer {
v8::MaybeLocal<v8::Object> New(Environment* env, size_t size);
// Makes a copy of |data|.
v8::MaybeLocal<v8::Object> New(Environment* env, const char* data, size_t len);
// Takes ownership of |data|.
v8::MaybeLocal<v8::Object> New(Environment* env,
char* data,
size_t length,
void (*callback)(char* data, void* hint),
void* hint);
// Takes ownership of |data|. Must allocate |data| with malloc() or realloc()
// because ArrayBufferAllocator::Free() deallocates it again with free().
// Mixing operator new and free() is undefined behavior so don't do that.
v8::MaybeLocal<v8::Object> Use(Environment* env, char* data, size_t length);
} // namespace Buffer

} // namespace node

#endif // SRC_NODE_INTERNALS_H_