-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[10.x] deps: V8: cherry-pick 52a9e67 #25027
Conversation
Original commit message: [turbofan] Fix ObjectCreate's side effect annotation. Bug: chromium:888923 Change-Id: Ifb22cd9b34f53de3cf6e47cd92f3c0abeb10ac79 Reviewed-on: https://chromium-review.googlesource.com/1245763 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Jaroslav Sevcik <[email protected]> Cr-Commit-Position: refs/heads/master@{#56236} Refs: v8/v8@52a9e67
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19509/ |
Is the test-bootstrap-modules failure on CI with |
It doesn't repro on my machine. I've launched that worker job again: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/3258/. |
To repro locally, you ran it with something like this?:
(The |
Yeah. I cannot seem to be able to reproduce this with that command, or with the command to run the whole default suite. It would be good to know if there are other environmental differences on that "freestyle" job. |
Here it is happening on a different v10.x PR/CI run. So I think the test is just broken on v10.x-staging. https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/3261/ @nodejs/releasers How to proceed here? Land anyway and a releaser will bisect to figure out where/when CI started failing? 😱 |
Possibly relevant: #23876 Also: /ping @nodejs/workers |
AFAICT, the test starting failing at e872089 |
@codebytere ^^^^^^^^^^ |
looks like this is a new build target. Is it failing anywhere else? cc @nodejs/build |
Fixing the regression in this pre-req change: #25112 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Original commit message: [turbofan] Fix ObjectCreate's side effect annotation. Bug: chromium:888923 Change-Id: Ifb22cd9b34f53de3cf6e47cd92f3c0abeb10ac79 Reviewed-on: https://chromium-review.googlesource.com/1245763 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Jaroslav Sevcik <[email protected]> Cr-Commit-Position: refs/heads/master@{#56236} Refs: v8/v8@52a9e67 PR-URL: #25027 Refs: v8/v8@52a9e67 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Myles Borins <[email protected]>
landed in 844bd62 |
Original commit message: [turbofan] Fix ObjectCreate's side effect annotation. Bug: chromium:888923 Change-Id: Ifb22cd9b34f53de3cf6e47cd92f3c0abeb10ac79 Reviewed-on: https://chromium-review.googlesource.com/1245763 Reviewed-by: Benedikt Meurer <[email protected]> Commit-Queue: Jaroslav Sevcik <[email protected]> Cr-Commit-Position: refs/heads/master@{#56236} Refs: v8/v8@52a9e67 PR-URL: #25027 Refs: v8/v8@52a9e67 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Myles Borins <[email protected]>
Original commit message:
Refs: v8/v8@52a9e67
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesV8-CI: https://ci.nodejs.org/view/All/job/node-test-commit-v8-linux/1935/
CI: https://ci.nodejs.org/job/node-test-pull-request/19502/