console: add `inspectOptions` option #24978

BridgeAR · 2018-12-12T02:42:12Z

Add an inspectOptions option to the console constructor. That
way it's possible to define all inspection defaults for each
console instance instead of relying on the inspect() defaults.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Add an `inspectOptions` option to the `console` constructor. That way it's possible to define all inspection defaults for each `console` instance instead of relying on the `inspect()` defaults.

nodejs-github-bot · 2018-12-12T02:42:14Z

@BridgeAR build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1906/pipeline

BridgeAR · 2018-12-12T18:44:50Z

CI https://ci.nodejs.org/job/node-test-pull-request/19456/

BridgeAR · 2018-12-12T18:45:19Z

@nodejs/util PTAL

doc/api/console.md

Co-Authored-By: BridgeAR <[email protected]>

BridgeAR · 2018-12-13T06:57:14Z

CI https://ci.nodejs.org/job/node-test-pull-request/19476/
Resumed CI https://ci.nodejs.org/job/node-test-pull-request/19482/

BridgeAR · 2018-12-14T05:37:21Z

This could use some reviews.

mcollina

How would a user change the inspectOptions of the global/default console? It seems a needed feature.

If that's possible, we should document it and maybe add a test for it.

BridgeAR · 2018-12-14T11:46:06Z

@mcollina that's possible by changing util.inspect.defaultOptions. It is document in the util part. However, I would not want to document this any more prominent, since it's already used in userland modules and that's a pretty bad anti pattern. I am afraid more modules might change these defaults instead of relying on an individual logging instance (where it's totally fine to change the settings to their own needs).

The question does not seem to be directly related to this PR though.

mcollina

LGTM

Trott · 2018-12-15T05:31:27Z

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19556/ ✔️

doc/api/errors.md

lib/internal/console/constructor.js

BridgeAR · 2018-12-16T11:22:53Z

CI https://ci.nodejs.org/job/node-test-pull-request/19579/ ✔️

Trott · 2018-12-16T15:27:03Z

Removed author ready pending result of the conversation started in #24978 (comment). Just being cautious. No objections from me to landing.

has enough approvals

Add an `inspectOptions` option to the `console` constructor. That way it's possible to define all inspection defaults for each `console` instance instead of relying on the `inspect()` defaults. PR-URL: nodejs#24978 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]>

BridgeAR · 2018-12-17T15:44:06Z

Landed in be3ae33

MylesBorins · 2018-12-25T07:30:02Z

The tests for this PR fail on 11.x. Would someone be willing to open a backport?

BridgeAR · 2019-01-09T01:07:01Z

This relies on other console PRs and we should wait till those are backported. This should land cleanly afterwards.

Add an `inspectOptions` option to the `console` constructor. That way it's possible to define all inspection defaults for each `console` instance instead of relying on the `inspect()` defaults. PR-URL: #24978 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]>

BridgeAR · 2019-01-10T01:05:47Z

I was able to backport this directly to the staging branch due to recent console backports.

Add an `inspectOptions` option to the `console` constructor. That way it's possible to define all inspection defaults for each `console` instance instead of relying on the `inspect()` defaults. PR-URL: #24978 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]>

Add an `inspectOptions` option to the `console` constructor. That way it's possible to define all inspection defaults for each `console` instance instead of relying on the `inspect()` defaults. PR-URL: nodejs#24978 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gus Caplan <[email protected]>

Notable Changes * compression / zlib: * Added brotli support (Anna Henningsen and Zach Vacura) nodejs#24938 * console: * Added `inspectOptions` option (Ruben Bridgewater) nodejs#24978 * crypto: * Always accept private keys as public keys (Tobias Nießen) nodejs#25217 * deps: * Upgrade npm to v6.5.0 (Jordan Harband) nodejs#25234 * fs: * Use internalBinding('fs') internally instead of process.binding('fs') (Masashi Hirano) nodejs#22478 * http(s): * Support overriding http\\s.globalAgent (Roy Sommer) nodejs#25170 * util: * Inspect ArrayBuffers contents closely (Ruben Bridgewater) nodejs#25006 * worker: * Expose workers by default and remove `--experimental-worker` flag (Anna Henningsen) nodejs#25361 PR-URL: nodejs#25537

Notable Changes * compression / zlib: * Added brotli support (Anna Henningsen and Zach Vacura) #24938 * console: * Added `inspectOptions` option (Ruben Bridgewater) #24978 * crypto: * Always accept private keys as public keys (Tobias Nießen) #25217 * deps: * Upgrade npm to v6.5.0 (Jordan Harband) #25234 * fs: * Use internalBinding('fs') internally instead of process.binding('fs') (Masashi Hirano) #22478 * http(s): * Support overriding http\\s.globalAgent (Roy Sommer) #25170 * util: * Inspect ArrayBuffers contents closely (Ruben Bridgewater) #25006 * worker: * Expose workers by default and remove `--experimental-worker` flag (Anna Henningsen) #25361 PR-URL: #25537

console: add inspectOptions option

4925767

Add an `inspectOptions` option to the `console` constructor. That way it's possible to define all inspection defaults for each `console` instance instead of relying on the `inspect()` defaults.

BridgeAR added the semver-minor PRs that contain new features and should be released in the next minor version. label Dec 12, 2018

BridgeAR requested a review from addaleax December 12, 2018 02:42

nodejs-github-bot added console Issues and PRs related to the console subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Dec 12, 2018

Fishrock123 reviewed Dec 12, 2018

View reviewed changes

doc/api/console.md Outdated Show resolved Hide resolved

fixup: fix option name

e835030

Co-Authored-By: BridgeAR <[email protected]>

BridgeAR requested review from devsnek, jasnell, mcollina and ryzokuken December 14, 2018 11:30

mcollina reviewed Dec 14, 2018

View reviewed changes

mcollina approved these changes Dec 14, 2018

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 14, 2018

jasnell approved these changes Dec 15, 2018

View reviewed changes

addaleax previously approved these changes Dec 15, 2018

View reviewed changes

doc/api/errors.md Outdated Show resolved Hide resolved

lib/internal/console/constructor.js Show resolved Hide resolved

fixup: use a better error code

7c9bc12

Trott removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 16, 2018

devsnek approved these changes Dec 16, 2018

View reviewed changes

addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 17, 2018

BridgeAR closed this Dec 17, 2018

MylesBorins added the backport-requested-v11.x label Dec 25, 2018

targos mentioned this pull request Jan 1, 2019

console: improve inspectOptions validation #25090

Merged

3 tasks

BridgeAR added backported-to-v11.x and removed backport-requested-v11.x labels Jan 10, 2019

BridgeAR mentioned this pull request Jan 16, 2019

v11.7.0 proposal #25537

Merged

MylesBorins mentioned this pull request Jan 24, 2019

v11.8.0 proposal #25687

Merged

BethGriggs added the dont-land-on-v10.x label Sep 3, 2019

BridgeAR deleted the pass-through-console-options branch January 20, 2020 11:48

tniessen mentioned this pull request Feb 5, 2022

fs: support copy of relative links with cp and cpSync #41819

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

console: add `inspectOptions` option #24978

console: add `inspectOptions` option #24978

BridgeAR commented Dec 12, 2018

nodejs-github-bot commented Dec 12, 2018

BridgeAR commented Dec 12, 2018

BridgeAR commented Dec 12, 2018

BridgeAR commented Dec 13, 2018 •

edited

Loading

BridgeAR commented Dec 14, 2018

mcollina left a comment •

edited

Loading

BridgeAR commented Dec 14, 2018 •

edited

Loading

mcollina left a comment

Trott commented Dec 15, 2018 •

edited

Loading

BridgeAR commented Dec 16, 2018 •

edited by Trott

Loading

Trott commented Dec 16, 2018 •

edited

Loading

BridgeAR commented Dec 17, 2018

MylesBorins commented Dec 25, 2018

BridgeAR commented Jan 9, 2019

BridgeAR commented Jan 10, 2019

console: add inspectOptions option #24978

console: add inspectOptions option #24978

Conversation

BridgeAR commented Dec 12, 2018

Checklist

nodejs-github-bot commented Dec 12, 2018

BridgeAR commented Dec 12, 2018

BridgeAR commented Dec 12, 2018

BridgeAR commented Dec 13, 2018 • edited Loading

BridgeAR commented Dec 14, 2018

mcollina left a comment • edited Loading

Choose a reason for hiding this comment

BridgeAR commented Dec 14, 2018 • edited Loading

mcollina left a comment

Choose a reason for hiding this comment

Trott commented Dec 15, 2018 • edited Loading

BridgeAR commented Dec 16, 2018 • edited by Trott Loading

Trott commented Dec 16, 2018 • edited Loading

BridgeAR commented Dec 17, 2018

MylesBorins commented Dec 25, 2018

BridgeAR commented Jan 9, 2019

BridgeAR commented Jan 10, 2019

console: add `inspectOptions` option #24978

console: add `inspectOptions` option #24978

BridgeAR commented Dec 13, 2018 •

edited

Loading

mcollina left a comment •

edited

Loading

BridgeAR commented Dec 14, 2018 •

edited

Loading

Trott commented Dec 15, 2018 •

edited

Loading

BridgeAR commented Dec 16, 2018 •

edited by Trott

Loading

Trott commented Dec 16, 2018 •

edited

Loading