Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-cli-syntax as flaky/unreliable #24957

Closed
wants to merge 1 commit into from
Closed

test: mark test-cli-syntax as flaky/unreliable #24957

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 11, 2018 •
edited
Loading

Collaborators, 👍 here to fast-track.

I hate to do this with a bug that occurs so frequently in CI and is likely to be significant in some environments, but if a fix isn't imminent, this is the right thing to do, I suppose...

Refs: #24403

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 11, 2018
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1894/pipeline

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 11, 2018
@Trott
Copy link
Member Author

Trott commented Dec 11, 2018 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/19419/

CI: https://ci.nodejs.org/job/node-test-pull-request/19422/ (remembering to check CERTIFY_SAFE this time...)

cclauss
cclauss approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks 💯 correct to me!

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 11, 2018
@Trott
Copy link
Member Author

Trott commented Dec 11, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19428/

@Trott
Copy link
Member Author

Trott commented Dec 11, 2018

Landed in 73ebfc2

@Trott Trott closed this Dec 11, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 11, 2018
@Trott
test: mark test-cli-syntax as flaky/unreliable
73ebfc2 
Refs: nodejs#24403

PR-URL: nodejs#24957
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
@Trott @BethGriggs
test: mark test-cli-syntax as flaky/unreliable
22b6bef 
Refs: #24403

PR-URL: #24957
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelop beevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott @refack
test: mark test-cli-syntax as flaky/unreliable
c5a563f 
Refs: nodejs#24403

PR-URL: nodejs#24957
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@Trott @BethGriggs
test: mark test-cli-syntax as flaky/unreliable
2869b78 
Refs: #24403

PR-URL: #24957
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@Trott @BethGriggs
test: mark test-cli-syntax as flaky/unreliable
6c5eb1f 
Refs: #24403

PR-URL: #24957
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Trott @rvagg
test: mark test-cli-syntax as flaky/unreliable
eafe870 
Refs: #24403

PR-URL: #24957
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@Trott Trott deleted the cli-syntax-flaky branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@cclauss cclauss cclauss approved these changes

@watilde watilde watilde approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @nodejs-github-bot @addaleax @watilde @cclauss @richardlau @gireeshpunathil @BethGriggs