inspector: migrate process.binding to internalBinding

[BeniCheni]

Refs #22160, this PR attempts to migrate process.binding('inspector') to internalBinding('inspector').

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[joyeecheung]

CI: https://ci.nodejs.org/job/node-test-pull-request/19374/ ✔️

[BeniCheni]

Hi reviewers,

Would like some mentoring on these observations.

Couldn't change these inline code w. process.binding('inspector'). If using internalBinding('inspector'), tests seemed to failed with ReferenceError: internalBinding is not defined:

• lib/internal/bootstrap/node.js#L663

return `process.binding('inspector')...`

• test/sequential/test-inspector-async-hook-setup-at-signal.js#L16

const script = `
  ...
  if (!process.binding('inspector').isEnabled()) return;

• test/sequential/test-inspector-enabled.js#L9

const script = `
...
const inspector = process.binding('inspector');

Another observation is when seemingly inside a child process, I would also run into failed test if using internalBinding

• test/sequential/test-inspector-async-call-stack-abort.js#L15

if (process.argv[2] === 'child') {
  ...
  const { registerAsyncHook } = process.binding('inspector');

P.S.: I've experimented w. // Flags: --expose-internals & const { internalBinding } = require('internal/test/binding');, but no luck.

[devsnek]

wrapForBreakOnFirstLine is concerning. i think we should be able to use the inspector api to set a breakpoint instead of modifying the code? cc @nodejs/v8-inspector

[joyeecheung]

@BeniCheni

For the test failures (ReferenceErrors), you'd need to obtain internalBinding via const { internalBinding } = require('internal/test/binding'); (which also needs --expose-internals)

For the wrapForBreakOnFirstLine, maybe instead of wrapping the source and pass it to callAndPauseOnStart, prepending a debugger; statement to the source would work, but I am not really sure

[joyeecheung]

BTW, do we even need to wrap that in wrapForBreakOnFirstLine? module._compile is already wrapping the source with callAndPauseOnStart if process._breakFirstLine is true

[joyeecheung]

I implemented the part about -e --inspect-brk in #24946 since it involves quite of bit of changes in the inspector tests.

[danbev]

Landed in 0500237.

[MylesBorins]

This doesn't land cleanly on v11.x, would someone be willing to make a backport?