Fix test-http2-session-timeout.js and move to parallel #24877

Trott · 2018-12-06T18:30:45Z

First commit:

test: make http2 timeout test robust

Instead of using magic values for the server timeout in
test-http2-session-timeout, measure the duration of the first request
(which should be longer than subsequent requests) and use that value.

Fixes: https://github.com/nodejs/node/issues/20628

Second commit:

test: move http2 test to parallel

A fix to test-http2-session-timeout makes it sufficiently robust that it
can be moved to the parallel directory.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

nodejs-github-bot · 2018-12-06T18:30:47Z

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1856/pipeline

Trott · 2018-12-06T18:31:40Z

The test now passes under heavy load in parallel:

$ tools/test.py --repeat 192 -j 96 test/parallel/test-http2-session-timeout.js 
[00:18|% 100|+ 192|-   0]: Done 
$

On master, moving it to parallel makes it trivial to break with even a relatively small load:

$ tools/test.py --repeat 16 -j 16 test/parallel/test-http2-session-timeout.js 
=== release test-http2-session-timeout ===                   
Path: parallel/test-http2-session-timeout
assert.js:128
  throw err;
  ^

AssertionError [ERR_ASSERTION]: Timeout after 40 request(s)
    at Http2Server.mustNotCall (/Users/trott/io.js/test/parallel/test-http2-session-timeout.js:13:10)
    at Http2Server.emit (events.js:189:13)
    at ServerHttp2Session.sessionOnTimeout (internal/http2/core.js:2622:15)
    at Object.onceWrapper (events.js:277:13)
    at ServerHttp2Session.emit (events.js:189:13)
    at ServerHttp2Session._onTimeout (internal/http2/core.js:1307:10)
    at listOnTimeout (timers.js:324:15)
    at processTimers (timers.js:268:5)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-http2-session-timeout.js
=== release test-http2-session-timeout ===                   
Path: parallel/test-http2-session-timeout
assert.js:128
  throw err;
  ^

AssertionError [ERR_ASSERTION]: Timeout after 130 request(s)
    at Http2Server.mustNotCall (/Users/trott/io.js/test/parallel/test-http2-session-timeout.js:13:10)
    at Http2Server.emit (events.js:189:13)
    at ServerHttp2Session.sessionOnTimeout (internal/http2/core.js:2622:15)
    at Object.onceWrapper (events.js:277:13)
    at ServerHttp2Session.emit (events.js:189:13)
    at ServerHttp2Session._onTimeout (internal/http2/core.js:1307:10)
    at listOnTimeout (timers.js:324:15)
    at processTimers (timers.js:268:5)
Command: out/Release/node /Users/trott/io.js/test/parallel/test-http2-session-timeout.js
[00:01|% 100|+  14|-   2]: Done                              
$

Instead of using magic values for the server timeout in test-http2-session-timeout, measure the duration of the first request (which should be longer than subsequent requests) and use that value. Fixes: nodejs#20628

A fix to test-http2-session-timeout makes it sufficiently robust that it can be moved to the parallel directory.

Trott · 2018-12-06T18:35:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/19279/

mcollina

LGTM, brilliant technique!

Trott · 2018-12-07T03:11:44Z

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19289/ ✔️

Trott · 2018-12-08T20:35:47Z

Landed in 008b904...9df18ad

Instead of using magic values for the server timeout in test-http2-session-timeout, measure the duration of the first request (which should be longer than subsequent requests) and use that value. Fixes: nodejs#20628 PR-URL: nodejs#24877 Fixes: nodejs#20628 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>

A fix to test-http2-session-timeout makes it sufficiently robust that it can be moved to the parallel directory. PR-URL: nodejs#24877 Fixes: nodejs#20628 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>

Instead of using magic values for the server timeout in test-http2-session-timeout, measure the duration of the first request (which should be longer than subsequent requests) and use that value. Fixes: #20628 PR-URL: #24877 Fixes: #20628 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>

A fix to test-http2-session-timeout makes it sufficiently robust that it can be moved to the parallel directory. PR-URL: #24877 Fixes: #20628 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>