Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs, dns: simplify promises warning logic #24788

Closed
wants to merge 2 commits into from
Closed

fs, dns: simplify promises warning logic #24788

wants to merge 2 commits into from

Commits on Dec 2, 2018

  1. fs: simplify fs.promises warning logic 

    fs.promises is lazy loaded. Instead of using a seaparate
Boolean flag to track whether or not it has been loaded, just
inspect the state of the lazy loaded module itself.
    @cjihrig
    cjihrig committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    840f428 View commit details
    Browse the repository at this point in the history

  2. dns: simplify dns.promises warning logic 

    dns.promises is lazy loaded. Instead of using a seaparate
Boolean flag to track whether or not it has been loaded, just
inspect the state of the lazy loaded module itself.
    @cjihrig
    cjihrig committed Dec 2, 2018
    Configuration menu
    Copy the full SHA
    93f872c View commit details
    Browse the repository at this point in the history