Merge v3.1.0 into next+1 #2452
Closed
Merge v3.1.0 into next+1 #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voted in to Node.js Foundation TSC in meeting on 2015-06-17 Closes: nodejs#1500 Closes: nodejs#1501 PR-URL: nodejs#2008 Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: nodejs#1700 Reviewed-By: Ben Noordhuis <[email protected]>
In configure, the --with-dtrace option only showed that it was true by default on sunos. It is also true by default on darwin. PR-URL: nodejs#2019 Reviewed-By: Johan Bergström <[email protected]>
Not using test_ca.pem in these files anymore. Using elipses.txt which has multibyte chars. Not clear what constitutes "large" but that can be a different ticket if elipses.txt etc. are insufficiently large. PR-URL: nodejs#2032 Reviewed-By: Trevor Norris <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
The readfile/pipe tests rely on pre-existing pipes in the system. This arguably tests the OS functionality and not really io.js functionality. Removing TODOs. PR-URL: nodejs#2033 Reviewed-By: Trevor Norris <[email protected]>
closes: nodejs#41 PR-URL: nodejs#2037 Reviewed-By: Ben Noordhuis <[email protected]>
PR-URL: nodejs#2034 Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#2048 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]>
PR-URL: nodejs#850 Reviewed-By: Stephen Belanger <[email protected]>
vcbuild.bat calls python configure before setting GYP_MSVS_VERSION, so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py) defaults to 'auto' and selects VS 2005. vcbuild sets the environment in the current shell, so this issue would manifest itself only on the first invocation of the script in any given shell windows. Reviewed-By: Julien Gilli <[email protected]> PR-URL: nodejs/node-v0.x-archive#20109
PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <[email protected]>
PR-URL: nodejs#2036 Reviewed-By: Alexis Campailla <[email protected]>
Instead of not running the dgram-bind-shared-ports on Windows, check that it gets ENOTSUP. PR-URL: nodejs#2035 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
PR-URL: nodejs#1938 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Alexis Campailla <[email protected]>
On upgrading openssl, all symlinks in pulic header files are replaced with nested include files. The issue was raised that installing them leads to lost its references to real header files. To avoid this, all public header files are copied into the `deps/openssl/openssl/include/openssl/` directory. As a result, we have duplicated header files under `deps/openssl/openssl/` but copied files are refereed in build as specified to include path in openssl.gyp. Fixes: nodejs#1975 PR-URL: nodejs#2016 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
to replace the full src download by node-gyp, using the proper format instead of the full source format PR-URL: nodejs#1975 Reviewed-By: William Blankenship <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Refs: nodejs#2050 PR-URL: nodejs#2053 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Use vm.isContext() to properly identify contexts. PR-URL: nodejs/node-v0.x-archive#25382 PR-URL: nodejs#2052 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
Fix the regexp used to detect 'Unexpected token' errors so that they can be considered as recoverable. This fixes the following use case: > var foo = 'bar \ ... baz'; undefined > foo 'bar baz' > Fixes: nodejs/node-v0.x-archive#8874 PR-URL: nodejs/node-v0.x-archive#8875 PR-URL: nodejs#2052 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
test-repl-tab-complete.js contains numerous assertions that are never run. Anything that results in a ReferenceError bails out, and never calls the functions containing the assertions. This commit adds checking for successful tab completions, as well as ReferenceErrors. PR-URL: nodejs#2052 Reviewed-By: Ben Noordhuis <[email protected]>
Break up Buffer#toString() into a fast and slow path. The fast path optimizes for zero-length buffers and no-arg method invocation. The speedup for zero-length buffers is a satisfying 700%. The no-arg toString() operation gets faster by about 13% for a one-byte buffer. This change exploits the fact that most Buffer#toString() calls are plain no-arg method calls. Rewriting the method to take no arguments means a call doesn't go through an ArgumentsAdaptorTrampoline stack frame in the common case. PR-URL: nodejs#2027 Reviewed-By: Brian White <[email protected]> Reviewed-By: Christian Tellnes <[email protected]> Reviewed-By: Daniel Cousens <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
PR-URL: nodejs#2042 Reviewed-By: Brendan Ashworth <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
Tests in the disabled directory are not used by Makefile nor by the CI. Other than a single 2015 commit that puts 'use strict' in each test, many of them haven't been touched in years. This removes all the disabled tests that have been unmodified since 2011 (with the exception of the 'use strict' modification mentioned above). PR-URL: nodejs#2045 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Evan Lucas <[email protected]>
If an object's prototype is munged it's possible to bypass the instanceof check and cause the application to abort. Instead now use HasInstance() to verify that the object is a Buffer, and throw if not. This check will not work for JS only methods. So while the application won't abort, it also won't throw. In order to properly throw in all cases with toString() the JS optimization of checking that length is zero has been removed. In its place the native methods will now return early if a zero length string is detected. Ref: nodejs#1486 Ref: nodejs#1922 Fixes: nodejs#1485 PR-URL: nodejs#2012 Reviewed-By: Ben Noordhuis <[email protected]>
Prevent debug call from showing [object Object] for dnsopts in lookupAndConnect PR-URL: nodejs#2059 Reviewed-by: Colin Ihrig <[email protected]>
this opts for stream.push('') which has the same effect
but uses a public API.
PR-URL: nodejs#454
Reviewed-By: Fedor Indutny <[email protected]>
3beb880 has a bug in VerifyCallback when preverify is 1 and the cert chain has an verify error. If the error is UNABLE_TO_GET_ISSUER_CERT_LOCALLY, it leads an assertion error in finding rootCA. The whitelist check should be made only when the cert chain has no verify error with X509_V_OK. Fixes: nodejs#2061 PR-URL: nodejs#2064 Reviewed-By: Ben Noordhuis <[email protected]>
This was referenced Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While #2321 is stalled behind a ARMv6 issue being investigated, the
next+1branch is getting really out-of-date. I decided to do the merge separately from the V8 upgrade.CI: https://jenkins-iojs.nodesource.com/job/node-test-commit/209/
R=@bnoordhuis