Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove sudo:false from .travis.yml #24511

Closed
wants to merge 1 commit into from
Closed

build: remove sudo:false from .travis.yml #24511

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 20, 2018

sudo:false is being removed by Travis CI. Travis CI recommends removing
the configuration.

Fixes: #24510

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@Trott
build: remove sudo:false from .travis.yml
b58440e 
sudo:false is being removed by Travis CI. Travis CI recommends removing
the configuration.

Fixes: nodejs#24510
@nodejs-github-bot
Copy link
Collaborator

@Trott sadly an error occured when I tried to trigger a build :(

@Trott Trott mentioned this pull request Nov 20, 2018
Closed
@addaleax
Copy link
Member

If we’re doing this anyway – can we do something like https://github.com/guard/listen/wiki/Increasing-the-amount-of-inotify-watchers to resolve #21310 / #22589?

@Trott
Copy link
Member Author

Trott commented Nov 20, 2018 •
edited
Loading

If we’re doing this anyway – can we do something like https://github.com/guard/listen/wiki/Increasing-the-amount-of-inotify-watchers to resolve #21310 / #22589?

Since the change in this PR will move us from a fast-boot time environment to a full virtual machine per build, might it make sense to take a wait-and-see approach to see if this fixes itself automatically?

(If not, yeah, we can try putting something like that in .travis.yml to see if it solves the problem.)

addaleax
addaleax approved these changes Nov 20, 2018
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I’m good with seeing whether this might already be a solution :)

@Trott Trott mentioned this pull request Nov 20, 2018
Closed
4 tasks
@refack refack added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. meta Issues and PRs related to the general management of the project. fast-track PRs that do not need to wait for 48 hours to land. labels Nov 20, 2018
@refack
Copy link
Contributor

refack commented Nov 20, 2018 •
edited
Loading

Reviewers please 👍 if you approve this for fast-tracking.

@Trott
Copy link
Member Author

Trott commented Nov 20, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1658/

Trott added a commit to Trott/io.js that referenced this pull request Nov 20, 2018
@Trott
build: remove sudo:false from .travis.yml
64cabc6 
sudo:false is being removed by Travis CI. Travis CI recommends removing
the configuration.

Fixes: nodejs#24510

PR-URL: nodejs#24511
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@Trott
Copy link
Member Author

Trott commented Nov 20, 2018

Landed in 64cabc6

@Trott Trott closed this Nov 20, 2018
targos pushed a commit that referenced this pull request Nov 21, 2018
@Trott @targos
build: remove sudo:false from .travis.yml
34f9810 
sudo:false is being removed by Travis CI. Travis CI recommends removing
the configuration.

Fixes: #24510

PR-URL: #24511
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@Trott @rvagg
build: remove sudo:false from .travis.yml
39614ad 
sudo:false is being removed by Travis CI. Travis CI recommends removing
the configuration.

Fixes: #24510

PR-URL: #24511
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@Trott @codebytere
build: remove sudo:false from .travis.yml
aa7fd82 
sudo:false is being removed by Travis CI. Travis CI recommends removing
the configuration.

Fixes: #24510

PR-URL: #24511
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott @refack
build: remove sudo:false from .travis.yml
198ee1e 
sudo:false is being removed by Travis CI. Travis CI recommends removing
the configuration.

Fixes: nodejs#24510

PR-URL: nodejs#24511
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@Trott @codebytere
build: remove sudo:false from .travis.yml
b61a51c 
sudo:false is being removed by Travis CI. Travis CI recommends removing
the configuration.

Fixes: #24510

PR-URL: #24511
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@Trott Trott deleted the sudo-false branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use new Travis CI infrastructure
9 participants
@Trott @nodejs-github-bot @addaleax @refack @thefourtheye @targos @joyeecheung @richardlau @BridgeAR