Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replaced anonymous fns with arrow syntax #24444

Closed
wants to merge 2 commits into from
Closed

test: replaced anonymous fns with arrow syntax #24444

wants to merge 2 commits into from

Conversation

pushkalb123
Copy link
Contributor

@pushkalb123 pushkalb123 commented Nov 17, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 17, 2018
targos
targos reviewed Nov 17, 2018
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message should start with test: replace ...

test/parallel/test-stream-pipe-flow.js Outdated Show resolved Hide resolved
@targos targos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 17, 2018
@pushkalb123
Copy link
Contributor Author

@targos Accepted the changes. Please take a look at it.

targos
targos approved these changes Nov 17, 2018
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@targos
Copy link
Member

targos commented Nov 17, 2018

👍 to fast-track

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 17, 2018
@Trott
Copy link
Member

Trott commented Nov 17, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18702/

@Trott
Copy link
Member

Trott commented Nov 18, 2018

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18716/

@Trott
Copy link
Member

Trott commented Nov 18, 2018

Landed in b3b5fc7.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Nov 18, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 18, 2018
@pushkalb123 @Trott
test: use arrow functions for callbacks
b3b5fc7 
PR-URL: nodejs#24444
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
targos pushed a commit that referenced this pull request Nov 18, 2018
@pushkalb123 @targos
test: use arrow functions for callbacks
4e47f24 
PR-URL: #24444
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@pushkalb123 @rvagg
test: use arrow functions for callbacks
856a0fc 
PR-URL: #24444
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Jan 13, 2019
@pushkalb123 @codebytere
test: use arrow functions for callbacks
48e6be0 
PR-URL: #24444
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@pushkalb123 @refack
test: use arrow functions for callbacks
5ad8cb2 
PR-URL: nodejs#24444
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
@codebytere codebytere mentioned this pull request Jan 15, 2019
Merged
codebytere pushed a commit that referenced this pull request Jan 29, 2019
@pushkalb123 @codebytere
test: use arrow functions for callbacks
518bc96 
PR-URL: #24444
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
This was referenced Jan 29, 2019
Closed
Closed
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pushkalb123 @targos @Trott @cjihrig @gireeshpunathil @nodejs-github-bot