-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: adjusting formatting when printing #24325
Conversation
- reduces page margins - removes emphasis from links - hides expandable history items - removes horizontal scrollbar from bottom of print output - reduce stability rectangle sizes - shrink headlines slightly - hide ToC (as it's unclickable when printed) Ref: https://thomashunter.name/nodejs-documentation-pdf
/cc @refack |
Hello @tlhunter and thank you for the contribution! |
Lite CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1586/ I'll setup a demo site so we can compare the generated docs. |
@nodejs/website |
Since these are all under LGTM |
- reduces page margins - removes emphasis from links - hides expandable history items - removes horizontal scrollbar from bottom of print output - reduce stability rectangle sizes - shrink headlines slightly - hide ToC (as it's unclickable when printed) Ref: https://thomashunter.name/nodejs-documentation-pdf PR-URL: nodejs#24325 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Bryan English <[email protected]>
Landed in 344a46a |
Post land visual test: Screenshot of print preview: Pre:Post: |
Maybe we can follow up with an improvement to the visual of |
I see this in print preview on chrome using @refack links. Pre:Post: |
@WaleedAshraf Do you have "Background Graphics" checked? |
@refack Got it. |
- reduces page margins - removes emphasis from links - hides expandable history items - removes horizontal scrollbar from bottom of print output - reduce stability rectangle sizes - shrink headlines slightly - hide ToC (as it's unclickable when printed) Ref: https://thomashunter.name/nodejs-documentation-pdf PR-URL: #24325 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Bryan English <[email protected]>
- reduces page margins - removes emphasis from links - hides expandable history items - removes horizontal scrollbar from bottom of print output - reduce stability rectangle sizes - shrink headlines slightly - hide ToC (as it's unclickable when printed) Ref: https://thomashunter.name/nodejs-documentation-pdf PR-URL: #24325 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Bryan English <[email protected]>
- reduces page margins - removes emphasis from links - hides expandable history items - removes horizontal scrollbar from bottom of print output - reduce stability rectangle sizes - shrink headlines slightly - hide ToC (as it's unclickable when printed) Ref: https://thomashunter.name/nodejs-documentation-pdf PR-URL: #24325 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Bryan English <[email protected]>
- reduces page margins - removes emphasis from links - hides expandable history items - removes horizontal scrollbar from bottom of print output - reduce stability rectangle sizes - shrink headlines slightly - hide ToC (as it's unclickable when printed) Ref: https://thomashunter.name/nodejs-documentation-pdf PR-URL: #24325 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Bryan English <[email protected]>
As a weekend project I built a PDF generator for the Node.js docs. This project required making small changes to the documentation CSS for aesthetics. Take a look at these PDF files to view the CSS changes in action.
Here's an overview of these changes:
> history
items since they're collapsed and unreadableChecklist