Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: lint to wrap markdown at 80 characters #24094

Closed
wants to merge 2 commits into from
Closed

tools: lint to wrap markdown at 80 characters #24094

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 5, 2018

Not sure what the whitespace thrashing in lint-md.js is all about, but it's a generated file so I'm reluctant to "fix" it. /cc @refack

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@Trott
doc: wrap GOVERNANCE.md at 80 characters
b6edd22 
This is in preparation for a markdown lint rule requiring lines to be
wrapped at 80 characters.
@Trott
tools: enable 80-char line length markdown linting
7faa65c
@nodejs-github-bot
Copy link
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1494/pipeline

@nodejs-github-bot nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Nov 5, 2018
@Trott Trott mentioned this pull request Nov 5, 2018
Merged
4 tasks
@refack
Copy link
Contributor

refack commented Nov 5, 2018

I could add a prettify/uglify step to the rollup if someone asks 🤷‍♂️

@vsemozhetbyt vsemozhetbyt added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. labels Nov 5, 2018
Trott added a commit to Trott/io.js that referenced this pull request Nov 7, 2018
@Trott
doc: wrap GOVERNANCE.md at 80 characters
160ff64 
This is in preparation for a markdown lint rule requiring lines to be
wrapped at 80 characters.

PR-URL: nodejs#24094
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Trott added a commit to Trott/io.js that referenced this pull request Nov 7, 2018
@Trott
tools: enable 80-char line length markdown linting
c3809ff 
PR-URL: nodejs#24094
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott
Copy link
Member Author

Trott commented Nov 7, 2018

Landed in 1368eb8...c3809ff

(Aforementioned whitespace issues auto-squelched in the process of landing with ncu.)

@Trott Trott closed this Nov 7, 2018
@cjihrig cjihrig mentioned this pull request Nov 7, 2018
Closed
3 tasks
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@Trott @BridgeAR
doc: wrap GOVERNANCE.md at 80 characters
3ce71f7 
This is in preparation for a markdown lint rule requiring lines to be
wrapped at 80 characters.

PR-URL: #24094
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@Trott @BridgeAR
tools: enable 80-char line length markdown linting
6fdc5d9 
PR-URL: #24094
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@Trott @kiyomizumia
doc: wrap GOVERNANCE.md at 80 characters
17d523b 
This is in preparation for a markdown lint rule requiring lines to be
wrapped at 80 characters.

PR-URL: nodejs#24094
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@Trott @kiyomizumia
tools: enable 80-char line length markdown linting
f1822e3 
PR-URL: nodejs#24094
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Nov 29, 2018
@Trott @codebytere
doc: wrap GOVERNANCE.md at 80 characters
d081ef7 
This is in preparation for a markdown lint rule requiring lines to be
wrapped at 80 characters.

PR-URL: #24094
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
codebytere pushed a commit that referenced this pull request Nov 29, 2018
@Trott @codebytere
tools: enable 80-char line length markdown linting
277c366 
PR-URL: #24094
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@Trott @MylesBorins
doc: wrap GOVERNANCE.md at 80 characters
0e121bf 
This is in preparation for a markdown lint rule requiring lines to be
wrapped at 80 characters.

PR-URL: #24094
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@Trott @MylesBorins
tools: enable 80-char line length markdown linting
2015712 
PR-URL: #24094
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
@Trott @MylesBorins
doc: wrap GOVERNANCE.md at 80 characters
e0f99a2 
This is in preparation for a markdown lint rule requiring lines to be
wrapped at 80 characters.

PR-URL: #24094
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
@Trott @MylesBorins
tools: enable 80-char line length markdown linting
2152c07 
PR-URL: #24094
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@Trott Trott deleted the wrap-md-80 branch January 13, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @nodejs-github-bot @refack @lpinca @richardlau @codebytere @vsemozhetbyt