Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update alternative docs versions #23980

Merged
merged 1 commit into from
Nov 2, 2018
Merged

tools: update alternative docs versions #23980

merged 1 commit into from
Nov 2, 2018

Conversation

richardlau
Copy link
Member

@richardlau richardlau commented Oct 30, 2018 •
edited by refack
Loading

Add 11.x and mark 10.x as lts.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@richardlau build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1427/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Oct 30, 2018
@richardlau
Copy link
Member Author

cc @nodejs/documentation

@richardlau richardlau mentioned this pull request Oct 30, 2018
Closed
@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Oct 30, 2018 •
edited
Loading

We constantly forget about this update. Maybe this should be added to some release how-to?

@richardlau
Copy link
Member Author

We constantly forget about this update. Maybe this should be added to some release how-to?

That would be https://github.com/nodejs/node/blob/master/doc/releases.md.

There's also nodejs/nodejs-latest-linker#2 to add a latest-* link for the first new LTS release.

I'm going to be leaving the office soon(ish) but can raise a PR later/tomorrow. Unless someone else wants to take it (cc @nodejs/releasers ).

@richardlau
Copy link
Member Author

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1456/

@richardlau
tools: update alternative docs versions
a8e98f8 
Add `11.x` and mark `10.x` as `lts`.

PR-URL: nodejs#23980
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@richardlau
Copy link
Member Author

Landed in a8e98f8.

@richardlau richardlau merged commit a8e98f8 into nodejs:master Nov 2, 2018
targos pushed a commit that referenced this pull request Nov 2, 2018
@richardlau @targos
tools: update alternative docs versions
4d7fbc3 
Add `11.x` and mark `10.x` as `lts`.

PR-URL: #23980
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@richardlau @MylesBorins
tools: update alternative docs versions
e973b5d 
Add `11.x` and mark `10.x` as `lts`.

PR-URL: #23980
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@richardlau @MylesBorins
tools: update alternative docs versions
e45ea7e 
Add `11.x` and mark `10.x` as `lts`.

PR-URL: #23980
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 27, 2018
@richardlau @MylesBorins
tools: update alternative docs versions
d2400f5 
Add `11.x` and mark `10.x` as `lts`.

PR-URL: #23980
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@richardlau @rvagg
tools: update alternative docs versions
e84c01d 
Add `11.x` and mark `10.x` as `lts`.

PR-URL: #23980
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@richardlau @rvagg
tools: update alternative docs versions
c982a25 
Add `11.x` and mark `10.x` as `lts`.

PR-URL: #23980
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@richardlau @MylesBorins
tools: update alternative docs versions
add267b 
Add `11.x` and mark `10.x` as `lts`.

PR-URL: #23980
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
@richardlau @MylesBorins
tools: update alternative docs versions
fe75543 
Add `11.x` and mark `10.x` as `lts`.

PR-URL: #23980
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 4, 2018
Merged
This was referenced Dec 18, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@lpinca lpinca lpinca approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@richardlau @nodejs-github-bot @vsemozhetbyt @refack @lpinca @trivikr @MylesBorins