[v10.x backport] util: handle null prototype on inspect

[antsmartian]

This makes sure the  prototype is always detected properly.

PR-URL: https://github.com/nodejs/node/pull/22331
Fixes: https://github.com/nodejs/node/issues/22141
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: John-David Dalton <[email protected]>

Backport : https://github.com/nodejs/node/pull/22331/files

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[antsmartian]

The build is failing (https://travis-ci.com/nodejs/node/jobs/151670153) because WeakMap and BigUint64Array had different OP on 10.x. We need the following change:

diff --git a/test/parallel/test-util-inspect.js b/test/parallel/test-util-inspect.js
index b74fe00a61..f12b49c073 100644
--- a/test/parallel/test-util-inspect.js
+++ b/test/parallel/test-util-inspect.js
@@ -1678,8 +1678,8 @@ util.inspect(process);
   [new Map([[1, 2]]), '[Map: null prototype] { 1 => 2 }'],
   [new Promise((resolve) => setTimeout(resolve, 10)),
    '[Promise: null prototype] { <pending> }'],
-  [new WeakSet(), '[WeakSet: null prototype] { <items unknown> }'],
-  [new WeakMap(), '[WeakMap: null prototype] { <items unknown> }'],
+  [new WeakSet(), '[WeakSet: null prototype] { [items unknown] }'],
+  [new WeakMap(), '[WeakMap: null prototype] { [items unknown] }'],
   [new Uint8Array(2), '[Uint8Array: null prototype] [ 0, 0 ]'],
   [new Uint16Array(2), '[Uint16Array: null prototype] [ 0, 0 ]'],
   [new Uint32Array(2), '[Uint32Array: null prototype] [ 0, 0 ]'],
@@ -1688,8 +1688,8 @@ util.inspect(process);
   [new Int32Array(2), '[Int32Array: null prototype] [ 0, 0 ]'],
   [new Float32Array(2), '[Float32Array: null prototype] [ 0, 0 ]'],
   [new Float64Array(2), '[Float64Array: null prototype] [ 0, 0 ]'],
-  [new BigInt64Array(2), '[BigInt64Array: null prototype] [ 0n, 0n ]'],
-  [new BigUint64Array(2), '[BigUint64Array: null prototype] [ 0n, 0n ]'],
+  [new BigInt64Array(2), '[BigInt64Array: null prototype] [ 0, 0 ]'],
+  [new BigUint64Array(2), '[BigUint64Array: null prototype] [ 0, 0 ]'],
   [new ArrayBuffer(16), '[ArrayBuffer: null prototype] ' +
    '{ byteLength: undefined }'],
   [new DataView(new ArrayBuffer(16)),

If I add this change, that should go as different commit or to be combined in the same commit? cc @BridgeAR @targos. Thanks!

[targos]

You can combine in the same commit. Thanks for doing that!

[antsmartian]

Thanks @targos. I have taken care those changes.

[BridgeAR]

CI https://ci.nodejs.org/job/node-test-pull-request/17944/

[antsmartian]

hmmm, looks like conflict. Will get rebased with master.

[antsmartian]

@BridgeAR I have now rebased with staging branch, can you have a look at it and merge if all good please?

[BethGriggs]

Another CI: https://ci.nodejs.org/job/node-test-pull-request/18278/

[MylesBorins]

rebuild of OSX which failed due to infra: https://ci.nodejs.org/job/node-test-commit-osx/22376/

[MylesBorins]

landed in 3df083c

[antsmartian]

@MylesBorins Thanks!