Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: migrate to getOptions() #23562

Closed
wants to merge 1 commit into from

Conversation

nick-ng
Copy link
Contributor

@nick-ng nick-ng commented Oct 12, 2018

Migrating from process.binding('config') to getOptions() in crypto.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Migrating from process.binding('config') to getOptions() in crypto.js
@nodejs-github-bot nodejs-github-bot added the crypto Issues and PRs related to the crypto subsystem. label Oct 12, 2018
@jasnell jasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
@danbev
Copy link
Contributor

danbev commented Oct 16, 2018

@addaleax
Copy link
Member

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 16, 2018
@nick-ng
Copy link
Contributor Author

nick-ng commented Oct 16, 2018

Can I have some advice on how to fix the failing tests?

@addaleax
Copy link
Member

@nick-ng These should be unrelated to this PR, nothing to worry about…

New Resume CI: https://ci.nodejs.org/job/node-test-pull-request/17932/

@Trott
Copy link
Member

Trott commented Oct 18, 2018

@tniessen
Copy link
Member

Landed in 4e96845, thank you for your contribution!

@tniessen tniessen closed this Oct 19, 2018
tniessen pushed a commit that referenced this pull request Oct 19, 2018
Migrating from process.binding('config') to getOptions() in crypto.js.

PR-URL: #23562
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 21, 2018
Migrating from process.binding('config') to getOptions() in crypto.js.

PR-URL: #23562
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.