test: refactor callback functions to arrow functions #23546

seanhealy · 2018-10-12T17:49:44Z

Refactor callback functions to modern arrow functions.

Also, added common.mustCall to online callbacks.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

ChALkeR · 2018-10-12T17:57:04Z

test/parallel/test-cluster-worker-forced-exit.js

+  worker
+    .on('online', common.mustCall(() => worker.disconnect()))
+    .on(
+      'exit',


I suggest breaking the lines a bit differently, see e.g.

node/test/parallel/test-http2-ping-unsolicited-ack.js

Lines 19 to 25 in 8b4af64

server.on('session', common.mustCall((session) => {

session.on('error', common.expectsError({

code: 'ERR_HTTP2_ERROR',

message: 'Protocol error'

}));

session.on('close', common.mustCall(() => server.close()));

}));

Refactor callback functions to modern arrow functions. Also, added `common.mustCall` to `online` callbacks.

Refactor callback functions to modern arrow functions. Also, added `common.mustCall` to `online` callbacks. PR-URL: nodejs#23546 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

BridgeAR · 2018-10-15T10:20:58Z

Landed in f7a50f7 🎉

@seanhealy congratulations on your commit to Node.js!

Refactor callback functions to modern arrow functions. Also, added `common.mustCall` to `online` callbacks. PR-URL: #23546 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 12, 2018

targos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018

jasnell approved these changes Oct 12, 2018

View reviewed changes

ChALkeR reviewed Oct 12, 2018

View reviewed changes

test: refactor callback functions to arrow functions

d3a8ae0

Refactor callback functions to modern arrow functions. Also, added `common.mustCall` to `online` callbacks.

seanhealy force-pushed the move-to-arrow-functions branch from 82ba036 to d3a8ae0 Compare October 12, 2018 17:58

ChALkeR approved these changes Oct 12, 2018

View reviewed changes

trivikr approved these changes Oct 13, 2018

View reviewed changes

BridgeAR approved these changes Oct 15, 2018

View reviewed changes

BridgeAR closed this Oct 15, 2018

codebytere mentioned this pull request Nov 27, 2018

v10.13.1 proposal #24675

Closed

codebytere mentioned this pull request Nov 29, 2018

v10.14.2 proposal #24727

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: refactor callback functions to arrow functions #23546

test: refactor callback functions to arrow functions #23546

seanhealy commented Oct 12, 2018

ChALkeR Oct 12, 2018

BridgeAR commented Oct 15, 2018

	server.on('session', common.mustCall((session) => {
	session.on('error', common.expectsError({
	code: 'ERR_HTTP2_ERROR',
	message: 'Protocol error'
	}));
	session.on('close', common.mustCall(() => server.close()));
	}));

test: refactor callback functions to arrow functions #23546

test: refactor callback functions to arrow functions #23546

Conversation

seanhealy commented Oct 12, 2018

Checklist

ChALkeR Oct 12, 2018

Choose a reason for hiding this comment

BridgeAR commented Oct 15, 2018