Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: migrating process.binding to getOptions in default_resolve.js #23526

Closed
wants to merge 4 commits into from
Closed

lib: migrating process.binding to getOptions in default_resolve.js #23526

wants to merge 4 commits into from

Conversation

jonnyk20
Copy link
Contributor

@jonnyk20 jonnyk20 commented Oct 12, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included

@jasnell jasnell added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018
@targos targos added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Oct 12, 2018
devsnek
devsnek reviewed Oct 12, 2018
View reviewed changes
lib/internal/modules/esm/default_resolve.js Outdated
const preserveSymlinks = !!process.binding('config').preserveSymlinks;
const preserveSymlinksMain = !!process.binding('config').preserveSymlinksMain;
const { getOptions } = internalBinding('options');
const preserveSymlinks = !!getOptions('--preserve-symlinks');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the !!, getOptions already returns true/false

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be removed now!

@devsnek devsnek added the esm Issues and PRs related to the ECMAScript Modules implementation. label Oct 12, 2018
@devsnek
Copy link
Member

devsnek commented Oct 12, 2018

This is another case where this file has been modified heavily downstream in https://github.com/nodejs/ecmascript-modules. Not blocking but making sure people are keeping track of this.

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@jonnyk20 @BridgeAR
lib: migrate process.binding('config') to getOptions()
c5794ab 
PR-URL: nodejs#23526
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Oct 15, 2018
@jonnyk20 @BridgeAR
lib: migrate process.binding('config') to getOptions()
7e4cc76 
PR-URL: nodejs#23526
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR
Copy link
Member

Landed in 7e4cc76 🎉

@jonnyk20 congratulations on your commit to Node.js!

@BridgeAR BridgeAR closed this Oct 15, 2018
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@jonnyk20 @jasnell
lib: migrate process.binding('config') to getOptions()
66d4ac1 
PR-URL: #23526
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
addaleax pushed a commit that referenced this pull request Oct 20, 2018
@jonnyk20 @addaleax
lib: migrate process.binding('config') to getOptions()
f81b9cb 
PR-URL: #23526
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@jonnyk20 @MylesBorins
lib: migrate process.binding('config') to getOptions()
6eea5dc 
PR-URL: #23526
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@jonnyk20 @rvagg
lib: migrate process.binding('config') to getOptions()
b19972c 
PR-URL: #23526
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@jonnyk20 @MylesBorins
lib: migrate process.binding('config') to getOptions()
83f4fcc 
PR-URL: #23526
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devsnek devsnek devsnek left review comments

@trivikr trivikr trivikr approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. esm Issues and PRs related to the ECMAScript Modules implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jonnyk20 @devsnek @BridgeAR @jasnell @gireeshpunathil @trivikr @targos