swap actual and expected in assertions #23474

yitongding · 2018-10-12T17:04:32Z

test/parallel/test-fs-write.js contains assertions where the first
argument provided is the expected value and the second value is the
actual value. This is backward from the documentation for assertions
like assert.strictEqual() where the first value should be the actual
value being tested and the second value is the expected value.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

'test/parallel/test-fs-write.js' contains assertions where the first argument provided is the expected value and the second value is the actual value. This is backward from the documentation for assertions like 'assert.strictEqual()' where the first value should be the actual value being tested and the second value is the expected value.

gireeshpunathil · 2018-10-12T17:47:40Z

thanks for the detailed PR description!

Trott · 2018-10-14T01:10:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/17843/

addaleax · 2018-10-14T02:32:59Z

Landed in cf7b5a8...e48d9aa

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

'test/parallel/test-fs-write.js' contains assertions where the first argument provided is the expected value and the second value is the actual value. This is backward from the documentation for assertions like 'assert.strictEqual()' where the first value should be the actual value being tested and the second value is the expected value. PR-URL: #23474 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>

PR-URL: #23474 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>

'test/parallel/test-fs-write.js' contains assertions where the first argument provided is the expected value and the second value is the actual value. This is backward from the documentation for assertions like 'assert.strictEqual()' where the first value should be the actual value being tested and the second value is the expected value. PR-URL: #23474 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>

PR-URL: #23474 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>

'test/parallel/test-fs-write.js' contains assertions where the first argument provided is the expected value and the second value is the actual value. This is backward from the documentation for assertions like 'assert.strictEqual()' where the first value should be the actual value being tested and the second value is the expected value. PR-URL: #23474 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>

PR-URL: #23474 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>

'test/parallel/test-fs-write.js' contains assertions where the first argument provided is the expected value and the second value is the actual value. This is backward from the documentation for assertions like 'assert.strictEqual()' where the first value should be the actual value being tested and the second value is the expected value. PR-URL: #23474 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>

PR-URL: #23474 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>

'test/parallel/test-fs-write.js' contains assertions where the first argument provided is the expected value and the second value is the actual value. This is backward from the documentation for assertions like 'assert.strictEqual()' where the first value should be the actual value being tested and the second value is the expected value. PR-URL: #23474 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>

PR-URL: #23474 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>

'test/parallel/test-fs-write.js' contains assertions where the first argument provided is the expected value and the second value is the actual value. This is backward from the documentation for assertions like 'assert.strictEqual()' where the first value should be the actual value being tested and the second value is the expected value. PR-URL: #23474 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>

PR-URL: #23474 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>

yitongding added 2 commits October 12, 2018 10:03

test: replace function with arrow function

31d05ab

nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 12, 2018

cjihrig approved these changes Oct 12, 2018

View reviewed changes

targos added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 12, 2018

gireeshpunathil approved these changes Oct 12, 2018

View reviewed changes

jasnell approved these changes Oct 12, 2018

View reviewed changes

trivikr approved these changes Oct 12, 2018

View reviewed changes

codebytere approved these changes Oct 13, 2018

View reviewed changes

Trott mentioned this pull request Oct 14, 2018

Code and learn rollup 2 #23651

Closed

addaleax added the fs Issues and PRs related to the fs subsystem / file system. label Oct 14, 2018

addaleax closed this Oct 14, 2018

yitongding deleted the fixAssertInTestWriteFile branch October 14, 2018 02:56

codebytere mentioned this pull request Nov 27, 2018

v10.13.1 proposal #24675

Closed

codebytere mentioned this pull request Nov 29, 2018

v10.14.2 proposal #24727

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

swap actual and expected in assertions #23474

swap actual and expected in assertions #23474

yitongding commented Oct 12, 2018

gireeshpunathil commented Oct 12, 2018

Trott commented Oct 14, 2018

addaleax commented Oct 14, 2018

swap actual and expected in assertions #23474

swap actual and expected in assertions #23474

Conversation

yitongding commented Oct 12, 2018

Checklist

gireeshpunathil commented Oct 12, 2018

Trott commented Oct 14, 2018

addaleax commented Oct 14, 2018