-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build,deps: enable building V8 as shared library #23202
Conversation
the incantation is `./configure ... -- -Dv8_dynamic=true`
Blocked by GYP bug/undefined behavior WRT defaults. |
Fixed, PTAL |
Can you explain (also in the commit log) why this is useful or necessary? |
@bnoordhuis To reduce the build time of debug builds |
@bnoordhuis (Just realized that you might mean "why not just use |
As mentioned by @joyeecheung, it makes linking the
We need to conditionally turn on Lines 261 to 266 in 80225d4
I am considering adding it as a flag to BTW: There's still is a bug, since now we need to also compile ICU with |
You can do that by guarding on |
What is this blocked on? |
Making it simpler (remove the new flag, and just guard for special cases using the existing V8 flag |
Motivation: Makes linking the
node
binary faster, which is especially significant when doing a debug build.The incantation is
./configure ... -- -Dv8_dynamic=true
Files will be in
out/[Release\Debug]/lib.target/libv8*.so
/CC @nodejs/build-files
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes