Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve test-gc-http-client-onerror #23196

Closed
wants to merge 1 commit into from
Closed

test: improve test-gc-http-client-onerror #23196

wants to merge 1 commit into from

Conversation

lundibundi
Copy link
Member

@lundibundi lundibundi commented Oct 1, 2018 •
edited
Loading

  • refactor out usage of 'function' for scoping
  • inline runTest function
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@lundibundi lundibundi self-assigned this Oct 1, 2018
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 1, 2018 •
edited by lundibundi
Loading

@lundibundi build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1085/pipeline

CI: https://ci.nodejs.org/job/node-test-pull-request/17556/

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 1, 2018
@joyeecheung joyeecheung mentioned this pull request Oct 2, 2018
Closed
@addaleax
Copy link
Member

addaleax commented Oct 4, 2018

decrease amount of requests 500 -> 300

I think that might help with masking a real problem, see nodejs/reliability#18 (comment).

@lundibundi
test: improve test-gc-http-client-onerror
acddd91 
* refactor out usage of 'function' for scoping
* inline runTest function
@lundibundi lundibundi force-pushed the improve-gc-http-onerror branch from 330c8e3 to acddd91 Compare October 8, 2018 22:55
@lundibundi
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/17691/

@lundibundi lundibundi added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 8, 2018
@addaleax
Copy link
Member

Landed in 0ea804a

@addaleax addaleax closed this Oct 12, 2018
addaleax pushed a commit that referenced this pull request Oct 12, 2018
@lundibundi @addaleax
test: improve test-gc-http-client-onerror
0ea804a 
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Trott pushed a commit that referenced this pull request Oct 13, 2018
@lundibundi @Trott
test: improve test-gc-http-client-onerror
0d7328d 
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
targos pushed a commit that referenced this pull request Oct 13, 2018
@lundibundi @targos
test: improve test-gc-http-client-onerror
e402b22 
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
@lundibundi @jasnell
test: improve test-gc-http-client-onerror
939a27e 
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
@lundibundi @MylesBorins
test: improve test-gc-http-client-onerror
21c3822 
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codebytere codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
@lundibundi @rvagg
test: improve test-gc-http-client-onerror
07c103d 
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
@lundibundi @MylesBorins
test: improve test-gc-http-client-onerror
8d091c2 
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: #23196
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@codebytere codebytere mentioned this pull request Nov 29, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

Assignees

@lundibundi lundibundi

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lundibundi @nodejs-github-bot @addaleax @jasnell @BridgeAR