Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make req_wrap a unique_ptr in AfterConnect #23115

Closed
wants to merge 1 commit into from
Closed

src: make req_wrap a unique_ptr in AfterConnect #23115

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Sep 27, 2018

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1037/pipeline

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. net Issues and PRs related to the net subsystem. labels Sep 27, 2018
@danbev
Copy link
Contributor Author

danbev commented Sep 27, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/17466/

@gireeshpunathil
Copy link
Member

On a slightly un-related note; what is the general convention on the responsibility of deleting heap objects - is it rested with the caller or callee (creator or consumer) ? or is it decided on a case basis? In the absence of a clear guidance, spotting memory leaks may be difficult?

@danbev
Copy link
Contributor Author

danbev commented Sep 27, 2018

is it rested with the caller or callee (creator or consumer) ? or is it decided on a case basis?

I would say that it depends on the situation and who owns the pointer, so it would be on a case basis I think.

@danbev danbev force-pushed the connection_wrap_unique_ptr branch 2 times, most recently from 7b202f3 to 312c959 Compare September 28, 2018 03:38
@danbev
Copy link
Contributor Author

danbev commented Sep 28, 2018

Rebased CI: https://ci.nodejs.org/job/node-test-pull-request/17489/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 30, 2018
@addaleax
Copy link
Member

Rebuild CI: https://ci.nodejs.org/job/node-test-pull-request/17527/

@danbev
Copy link
Contributor Author

danbev commented Oct 1, 2018 •
edited
Loading

Re-run of failing node-test-commit-windows-fanned/ ✔️

@danbev
Copy link
Contributor Author

danbev commented Oct 1, 2018

Landed in 5c855a7.

@danbev danbev closed this Oct 1, 2018
@danbev danbev deleted the connection_wrap_unique_ptr branch October 1, 2018 06:33
danbev added a commit that referenced this pull request Oct 1, 2018
@danbev
src: make req_wrap a unique_ptr in AfterConnect
5c855a7 
PR-URL: #23115
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos pushed a commit that referenced this pull request Oct 1, 2018
@danbev @targos
src: make req_wrap a unique_ptr in AfterConnect
279c07e 
PR-URL: #23115
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@joyeecheung joyeecheung mentioned this pull request Oct 2, 2018
Closed
targos pushed a commit that referenced this pull request Oct 3, 2018
@danbev @targos
src: make req_wrap a unique_ptr in AfterConnect
20a4f14 
PR-URL: #23115
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Sakthipriyan Vairamani <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Oct 7, 2018
Merged
This was referenced Oct 10, 2018
Closed
Closed
This was referenced Oct 11, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@addaleax addaleax addaleax approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@danbev @nodejs-github-bot @gireeshpunathil @addaleax @jasnell @thefourtheye @targos @cjihrig @joyeecheung