Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove GA tracking #23083

Closed
wants to merge 1 commit into from
Closed

Conversation

bnoordhuis
Copy link
Member

The Google Analytics tracking wasn't wholly uncontroversial and hasn't
been used in practice. Remove it.

Refs: #6601
Fixes: #22652

The Google Analytics tracking wasn't wholly uncontroversial and hasn't
been used in practice. Remove it.

Refs: nodejs#6601
Fixes: nodejs#22652
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Sep 25, 2018
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@MylesBorins
Copy link
Contributor

are we sure it is unused? /cc @nodejs/community-committee

@amiller-gh
Copy link
Member

Only use I've seen of the data is to help guide some focus in the website redesign initiative, but it didn't do much other than confirm already existing assumptions.

I'm personally always in favor of collecting more data on the off chance we need it / will find it useful in the future – but I also respect and understand the privacy concerns expressed by other people here, so I don't want to block this from happening unless others feel strongly to the contrary.

@bnb, any historical knowledge on how GA tracking has been used?

Copy link
Contributor

@silverwind silverwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Access logs are a better source for such data because I guess among the developer community, a reasonable amount of users would use a tracking blocker and these users would not be picked up by GA, but would still be visible in the access logs.

@keywordnew
Copy link
Contributor

I'm not familiar with the process to getting a hold of those. Are access logs a resource that to which we have reasonable access?

If we have (better) alternatives to the data collected by GA, then it would seem unnecessary.

@danbev
Copy link
Contributor

danbev commented Sep 28, 2018

@silverwind
Copy link
Contributor

Are access logs a resource that to which we have reasonable access?

I'm not that deeply involved in the organization, but I guess one could set up a log parser which can present similar stats than GA, without privacy concerns.

@refack
Copy link
Contributor

refack commented Sep 29, 2018

Are access logs a resource that to which we have reasonable access?

I'm not that deeply involved in the organization, but I guess one could set up a log parser which can present similar stats than GA, without privacy concerns.

I think ATM this falls under the BuildWG's responsibility. The current setup of the WWW server is mirrored in the scripts at https://github.com/nodejs/build/tree/master/setup/www (server is NGINX).
We already parse the logs to produce download statistics, but if we want stats on */api/*, something will need to be implemeted/developed.

@refack
Copy link
Contributor

refack commented Sep 29, 2018

P.S. this PR will probably not affect the existing documentation already deployed to the site:
image

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@addaleax
Copy link
Member

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 30, 2018
@danbev
Copy link
Contributor

danbev commented Oct 4, 2018

Re-run of failing node-test-commit-arm ✔️
Re-run of failing node-test-commit-windows-fanned ✔️

@danbev
Copy link
Contributor

danbev commented Oct 4, 2018

Landed in df6a130.

@danbev danbev closed this Oct 4, 2018
danbev pushed a commit that referenced this pull request Oct 4, 2018
The Google Analytics tracking wasn't wholly uncontroversial and hasn't
been used in practice. Remove it.

PR-URL: #23083
Fixes: #22652
Refs: #6601
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
targos pushed a commit that referenced this pull request Oct 4, 2018
The Google Analytics tracking wasn't wholly uncontroversial and hasn't
been used in practice. Remove it.

PR-URL: #23083
Fixes: #22652
Refs: #6601
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
The Google Analytics tracking wasn't wholly uncontroversial and hasn't
been used in practice. Remove it.

PR-URL: #23083
Fixes: #22652
Refs: #6601
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
SEWeiTung pushed a commit to nodejs/nodejs.org that referenced this pull request Jul 1, 2019
We removed GA in 2018 but it seems like we missed removing
it from the partials and it is still being loaded.

Refs: nodejs/node#23083
Refs: #2302
Trott pushed a commit to nodejs/nodejs.org that referenced this pull request Jul 1, 2019
It was still present in one file, previous
commit just removed the prefetch.

Also remove dnt_helper, it was used only by analytics.

Refs: #2305
Refs: nodejs/node#23083
Refs: nodejs/node#22652
Refs: #2302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.